From d70d7f5a4a7fc7057fe995bcc181e2264477ed34 Mon Sep 17 00:00:00 2001 From: Arpit Mohan Date: Sat, 10 Oct 2020 09:57:19 +0530 Subject: [PATCH 1/3] Getting Cypress to work correctly for internal pull requests (#1121) --- .github/workflows/client.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/client.yml b/.github/workflows/client.yml index cf91382238..b9ad10dae7 100644 --- a/.github/workflows/client.yml +++ b/.github/workflows/client.yml @@ -190,6 +190,10 @@ jobs: CYPRESS_TESTPASSWORD1: ${{ secrets.CYPRESS_TESTPASSWORD1 }} CYPRESS_TESTUSERNAME2: ${{ secrets.CYPRESS_TESTUSERNAME2 }} CYPRESS_TESTPASSWORD2: ${{ secrets.CYPRESS_TESTPASSWORD1 }} + COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }} + # Recommended: pass the GitHub token lets this action correctly + # determine the unique run id necessary to re-run the checks + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: browser: chrome headless: true @@ -200,6 +204,8 @@ jobs: ci-build-id: '${{ github.sha }}-${{ github.workflow }}-${{ github.event_name }}' spec: 'cypress/integration/Smoke_TestSuite/*/*' working-directory: app/client + # tag will be either "push" or "pull_request_target" + tag: ${{ github.event_name }} # Upload the screenshots as artifacts if there's a failure - uses: actions/upload-artifact@v1 From 4856300b632582246506d5e1b7ddaf6474c02c89 Mon Sep 17 00:00:00 2001 From: Arpit Mohan Date: Sat, 10 Oct 2020 10:00:41 +0530 Subject: [PATCH 2/3] Hotfix to fix the client build workflow --- .github/workflows/client.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/client.yml b/.github/workflows/client.yml index b9ad10dae7..3e1068a441 100644 --- a/.github/workflows/client.yml +++ b/.github/workflows/client.yml @@ -191,9 +191,6 @@ jobs: CYPRESS_TESTUSERNAME2: ${{ secrets.CYPRESS_TESTUSERNAME2 }} CYPRESS_TESTPASSWORD2: ${{ secrets.CYPRESS_TESTPASSWORD1 }} COMMIT_INFO_MESSAGE: ${{ github.event.pull_request.title }} - # Recommended: pass the GitHub token lets this action correctly - # determine the unique run id necessary to re-run the checks - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: browser: chrome headless: true From c9859030eae43e6cd055f9a5cec191d0a1b586de Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Sat, 10 Oct 2020 10:42:50 +0530 Subject: [PATCH 3/3] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 12768ddfeb..191a1aeb11 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ [![Chat on Discord](https://img.shields.io/badge/chat-Discord-violet?logo=discord)](https://discord.gg/rBTTVJp) [![Docs](https://img.shields.io/badge/docs-v1.x-brightgreen.svg?style=flat)](https://docs.appsmith.com) -[![All Contributors](https://img.shields.io/badge/all_contributors-18-orange.svg?style=flat-square)](#-contributors) +[![All Contributors](https://img.shields.io/badge/all_contributors-49-orange.svg?style=flat-square)](#-contributors)