From 0eb6ebf95aebbb71e0865cc60127229e462cbc4a Mon Sep 17 00:00:00 2001 From: Abhinav Jha Date: Thu, 17 Sep 2020 18:45:21 +0530 Subject: [PATCH 1/2] Increase clickable area of entities in explorer (#561) --- app/client/src/pages/Editor/Explorer/Entity/Name.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/app/client/src/pages/Editor/Explorer/Entity/Name.tsx b/app/client/src/pages/Editor/Explorer/Entity/Name.tsx index cc0148282a..dd070212e5 100644 --- a/app/client/src/pages/Editor/Explorer/Entity/Name.tsx +++ b/app/client/src/pages/Editor/Explorer/Entity/Name.tsx @@ -23,6 +23,7 @@ const Wrapper = styled.div` text-overflow: ellipsis; white-space: nowrap; margin: 0 4px; + padding: 9px 0; line-height: 13px; & span.token { color: ${Colors.OCEAN_GREEN}; From e688f6237894f2d5f96c36872167131fa09ab9ea Mon Sep 17 00:00:00 2001 From: Arpit Mohan Date: Thu, 17 Sep 2020 18:51:26 +0530 Subject: [PATCH 2/2] Removing cacheResponse from the JSON response for actions (#564) This is because this `cacheResponse` field is only used for auto-complete on the UI. The user can still run the action manually and get the auto-complete to work. The downside to sending the `cacheResponse` field in the JSON response is that for large responses, the client times out as our response times increase to 20 secs. Hence removing this for now. In future, we'll extract the JSON schema structure from the response body and send that to the client for populating auto-complete. --- .../src/main/java/com/appsmith/server/domains/Action.java | 1 + 1 file changed, 1 insertion(+) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Action.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Action.java index a68dba0777..77cada4a46 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Action.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/domains/Action.java @@ -56,6 +56,7 @@ public class Action extends BaseDomain { @JsonProperty(access = JsonProperty.Access.READ_ONLY) Set jsonPathKeys; + @JsonIgnore String cacheResponse; String templateId; //If action is created via a template, store the id here.