From 7c6434b7789900be6054e8f92a608fd656a58a3c Mon Sep 17 00:00:00 2001
From: Nilansh Bansal <nilansh@appsmith.com>
Date: Thu, 28 Dec 2023 12:49:21 +0530
Subject: [PATCH] chore: GSheet Internal error logging updated (#29897)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Description
>
**Context**

We have a limited quota on sentry, hence we want to utilize it
efficiently.

As part of https://github.com/appsmithorg/appsmith/issues/27444, we
debugged an issue with Google Sheets plugin which causes the sentry to
be overloaded with error messages for ***`QUERY_EXECUTION_FAILED`**.* On
debugging we found out that all these issues are coming from the Google
Sheets api, over which we have no control.

All these issues can be classified against the 500 server errors (from
Google).

Hence, we are removing these error logs from sentry and instead keeping
these logs in mezmo, so that our sentry quota is managed.

#### PR fixes following issue(s)
Fixes #27444

#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change
- Chore (housekeeping or task changes that don't impact user perception)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved error handling for specific Google Sheets plugin errors to
enhance user experience and troubleshooting.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../com/external/plugins/exceptions/GSheetsPluginError.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/plugins/exceptions/GSheetsPluginError.java b/app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/plugins/exceptions/GSheetsPluginError.java
index 4d3d60dffa..b715bac0ef 100644
--- a/app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/plugins/exceptions/GSheetsPluginError.java
+++ b/app/server/appsmith-plugins/googleSheetsPlugin/src/main/java/com/external/plugins/exceptions/GSheetsPluginError.java
@@ -11,7 +11,7 @@ public enum GSheetsPluginError implements BasePluginError {
             500,
             "PE-GSH-5000",
             "{0}",
-            AppsmithErrorAction.LOG_EXTERNALLY,
+            AppsmithErrorAction.DEFAULT,
             "Query execution error",
             ErrorType.INTERNAL_ERROR,
             "{1}",
@@ -20,7 +20,7 @@ public enum GSheetsPluginError implements BasePluginError {
             500,
             "PE-GSH-5001",
             "Error occurred while processing the response. Please check the error details for more information.",
-            AppsmithErrorAction.LOG_EXTERNALLY,
+            AppsmithErrorAction.DEFAULT,
             "Response processing error",
             ErrorType.INTERNAL_ERROR,
             "{1}",