From 7626d75ccf1e667dac4e850059ae4227d38fc3cf Mon Sep 17 00:00:00 2001
From: Rishabh Rathod <rishabh.rathod@appsmith.com>
Date: Tue, 12 Apr 2022 15:32:02 +0530
Subject: [PATCH] fix: remove "Error when determining async func" (#12683)

- Add logs for debugging
---
 app/client/src/workers/DataTreeEvaluator.ts | 3 ++-
 app/client/src/workers/evaluate.ts          | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/client/src/workers/DataTreeEvaluator.ts b/app/client/src/workers/DataTreeEvaluator.ts
index a849900254..362f7ee754 100644
--- a/app/client/src/workers/DataTreeEvaluator.ts
+++ b/app/client/src/workers/DataTreeEvaluator.ts
@@ -95,7 +95,7 @@ export default class DataTreeEvaluator {
   errors: EvalError[] = [];
   resolvedFunctions: Record<string, any> = {};
   currentJSCollectionState: Record<string, any> = {};
-  logs: any[] = [];
+  logs: unknown[] = [];
   allActionValidationConfig?: { [actionId: string]: ActionValidationConfigMap };
   public hasCyclicalDependency = false;
   constructor(
@@ -1076,6 +1076,7 @@ export default class DataTreeEvaluator {
                 action.value,
                 unEvalDataTree,
                 this.resolvedFunctions,
+                this.logs,
               ),
             };
           });
diff --git a/app/client/src/workers/evaluate.ts b/app/client/src/workers/evaluate.ts
index 9536eed56f..ffc6418d5e 100644
--- a/app/client/src/workers/evaluate.ts
+++ b/app/client/src/workers/evaluate.ts
@@ -354,6 +354,7 @@ export function isFunctionAsync(
   userFunction: unknown,
   dataTree: DataTree,
   resolvedFunctions: Record<string, any>,
+  logs: unknown[] = [],
 ) {
   return (function() {
     /**** Setting the eval context ****/
@@ -415,7 +416,9 @@ export function isFunctionAsync(
         }
       }
     } catch (e) {
-      console.error("Error when determining async function", e);
+      // We do not want to throw errors for internal operations, to users.
+      // logLevel should help us in debugging this.
+      logs.push({ error: "Error when determining async function" + e });
     }
     const isAsync = !!self.IS_ASYNC;
     for (const entity in GLOBAL_DATA) {