From 7515500da86daebbf7b6b4062c08c928b0c61368 Mon Sep 17 00:00:00 2001 From: Ankita Kinger Date: Wed, 23 Oct 2024 17:24:44 +0530 Subject: [PATCH] chore: Removing usage of action right pane component (#37020) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Removing usage of action right pane component to use Module inputs form directly as right pane on EE. Fixes [#36898](https://github.com/appsmithorg/appsmith/issues/36898) ## Automation /ok-to-test tags="@tag.Sanity" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: e404221a9e73ae6d45ac496905b5bf0a872eae22 > Cypress dashboard. > Tags: `@tag.Sanity` > Spec: >
Wed, 23 Oct 2024 08:15:44 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit - **New Features** - Simplified rendering of action sections in the `CommonEditorForm` and `EditorJSONtoForm` components by removing the `ActionRightPane` component. - **Bug Fixes** - No bug fixes were implemented; overall functionality remains consistent. - **Refactor** - Enhanced component structure for better direct manipulation of action sections. --- app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx | 5 +---- app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx b/app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx index 84f5dd24b9..10e04d269f 100644 --- a/app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx +++ b/app/client/src/pages/Editor/APIEditor/CommonEditorForm.tsx @@ -23,7 +23,6 @@ import { getHasManageActionPermission, } from "ee/utils/BusinessFeatures/permissionPageHelpers"; import { ApiEditorContext } from "./ApiEditorContext"; -import ActionRightPane from "components/editorComponents/ActionRightPane"; import RunHistory from "ee/components/RunHistory"; import { HintMessages } from "PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/HintMessages"; import { InfoFields } from "PluginActionEditor/components/PluginActionForm/components/CommonEditorForm/InfoFields"; @@ -347,9 +346,7 @@ function CommonEditorForm(props: CommonFormPropsWithExtraParams) { - + {actionRightPaneAdditionSections} diff --git a/app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx b/app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx index 5fffcc1dc9..d82a964021 100644 --- a/app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx +++ b/app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx @@ -17,7 +17,6 @@ import { import { useParams } from "react-router"; import type { AppState } from "ee/reducers"; import { thinScrollbar } from "constants/DefaultTheme"; -import ActionRightPane from "components/editorComponents/ActionRightPane"; import type { ActionResponse } from "api/ActionAPI"; import type { Plugin } from "api/PluginApi"; import type { UIComponentTypes } from "api/PluginApi"; @@ -377,7 +376,7 @@ export function EditorJSONtoForm(props: Props) { - + {actionRightPaneAdditionSections} );