From 732026fc06c199f9923fb200336d501a8269d5f5 Mon Sep 17 00:00:00 2001 From: Aman Agarwal Date: Mon, 8 Apr 2024 22:58:56 +0530 Subject: [PATCH] fix: label for data type in s3 create file action (#32484) --- .../e2e/Regression/ServerSide/QueryPane/S3_1_spec.js | 12 ++++++++++-- .../src/main/resources/editor/create.json | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js b/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js index 403a844423..0a778561c2 100644 --- a/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js +++ b/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js @@ -153,7 +153,11 @@ describe( response.body.data.pluginErrorDetails.appsmithErrorMessage, ).to.contains("File content is not base64 encoded."); }); - dataSources.ValidateNSelectDropdown("File data type", "Base64", "Text"); + dataSources.ValidateNSelectDropdown( + "File data type", + "Base64", + "Text / Binary", + ); dataSources.RunQuery({ toValidateResponse: false }); cy.wait("@postExecute").then(({ response }) => { @@ -417,7 +421,11 @@ describe( fileName = "S3Crud_" + uid; cy.typeValueNValidate(fileName, formControls.s3FilePath); - dataSources.ValidateNSelectDropdown("File data type", "Base64", "Text"); + dataSources.ValidateNSelectDropdown( + "File data type", + "Base64", + "Text / Binary", + ); cy.typeValueNValidate( '{"data": "Hi, this is Automation script adding file for S3 CRUD New Page validation!"}', formControls.rawBody, diff --git a/app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/create.json b/app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/create.json index 710a931e74..bd075899bc 100644 --- a/app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/create.json +++ b/app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/create.json @@ -41,7 +41,7 @@ "value": "YES" }, { - "label": "Text", + "label": "Text / Binary", "value": "NO" } ]