From 72d08b6c99c7c54d3cf5014eb78e7facdd8c9349 Mon Sep 17 00:00:00 2001 From: vicky-primathon <67091118+vicky-primathon@users.noreply.github.com> Date: Fri, 14 Aug 2020 14:30:59 +0530 Subject: [PATCH] Fix-Operator in table filter made as empty by default (#272) * Operator in filter made as empty be default * Added props.placeholder as dependency for useEffect in CascadeField component --- .../components/designSystems/appsmith/CascadeFields.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/app/client/src/components/designSystems/appsmith/CascadeFields.tsx b/app/client/src/components/designSystems/appsmith/CascadeFields.tsx index 341c52c0fe..9cc03b0158 100644 --- a/app/client/src/components/designSystems/appsmith/CascadeFields.tsx +++ b/app/client/src/components/designSystems/appsmith/CascadeFields.tsx @@ -211,9 +211,13 @@ const RenderOptions = (props: { ); if (selectedOptions && selectedOptions.length) { selectValue(selectedOptions[0].content); + } else { + selectValue(props.placeholder); } + } else { + selectValue(props.placeholder); } - }, [props.value, configs.sections]); + }, [props.value, props.placeholder, configs.sections]); return ; }; @@ -331,6 +335,7 @@ function CaseCaseFieldReducer( return { ...state, column: action.payload.value, + condition: "", conditions: typeOperatorsMap[type], showConditions: true, isUpdate: true, @@ -478,7 +483,7 @@ const Fields = (props: CascadeFieldProps & { state: CascadeFieldState }) => { columns={conditions} selectItem={selectCondition} value={condition} - placeholder="Is" + placeholder="" /> ) : null}