From 72c47ee27cb1be133c950596d5a78fc68df8e958 Mon Sep 17 00:00:00 2001 From: Ankita Kinger Date: Wed, 20 Aug 2025 11:39:59 +0530 Subject: [PATCH] fix: Removing a line of code to fix extra space issue on Page with Fixed height container (#41178) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Removing a line of code to fix extra space issue on Page with Fixed height container once switched from a Page with Auto height container. Also, manually tested out all issues from [#19082](https://github.com/appsmithorg/appsmith/pull/19082) to confirm nothing else breaks from the time these lines were added in the code. Fixes [#41180](https://github.com/appsmithorg/appsmith/issues/41180) ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: c8bde1226eed929dec92b1421a6167977486af97 > Cypress dashboard. > Tags: `@tag.All` > Spec: >
Mon, 18 Aug 2025 17:04:42 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No ## Summary by CodeRabbit * **Bug Fixes** * Improved main container auto-height calculation to eliminate unintended extra spacing, resulting in more accurate, content-driven sizing. * **Chores** * Added diagnostic logging around main container size computation in view mode to aid troubleshooting (no functional impact). --- app/client/src/sagas/autoHeightSagas/helpers.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/client/src/sagas/autoHeightSagas/helpers.ts b/app/client/src/sagas/autoHeightSagas/helpers.ts index 49bbba85c4..4e907fd6e1 100644 --- a/app/client/src/sagas/autoHeightSagas/helpers.ts +++ b/app/client/src/sagas/autoHeightSagas/helpers.ts @@ -204,10 +204,6 @@ export function* getMinHeightBasedOnChildren( } } - if (widgetId === MAIN_CONTAINER_WIDGET_ID) { - return minHeightInRows + GridDefaults.MAIN_CANVAS_EXTENSION_OFFSET; - } - return minHeightInRows; } /**