feat: allow HTTP port customization in Helm chart (#36763)
## Description See https://github.com/appsmithorg/appsmith/issues/36761 I've been tested this with ee Helm chart. Imho tcp/8080 should be the default port but to avoid breaking change, tcp/80 remains the default port if the new variable is not specified. Fixes #36761 ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [X] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced configurability of the HTTP container port through the introduction of a new variable (commented out). - Updated the Helm chart version from 2.1.0 to 2.2.0. - **Bug Fixes** - Improved indentation and formatting for better readability. - **Documentation** - Commented-out configuration for `HTTPContainerPort` included for future reference. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Damien LEGER <damien.leger@cure51.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Goutham Pratapa <pratapagoutham@gmail.com> Co-authored-by: Goutham Pratapa <goutham@appsmith.com>
This commit is contained in:
parent
6c1365673e
commit
72670ae114
|
|
@ -11,7 +11,7 @@ sources:
|
|||
- https://github.com/appsmithorg/appsmith
|
||||
home: https://www.appsmith.com/
|
||||
icon: https://assets.appsmith.com/appsmith-icon.png
|
||||
version: 2.2.0
|
||||
version: 2.2.1
|
||||
dependencies:
|
||||
- condition: redis.enabled
|
||||
name: redis
|
||||
|
|
|
|||
|
|
@ -70,7 +70,7 @@ spec:
|
|||
imagePullPolicy: {{ .Values.image.pullPolicy }}
|
||||
ports:
|
||||
- name: http
|
||||
containerPort: 80
|
||||
containerPort: {{ .Values.HTTPContainerPort | default 80 }}
|
||||
protocol: TCP
|
||||
- name: https
|
||||
containerPort: 443
|
||||
|
|
@ -101,6 +101,10 @@ spec:
|
|||
- name: data
|
||||
mountPath: /appsmith-stacks
|
||||
env:
|
||||
{{- if .Values.HTTPContainerPort }}
|
||||
- name: PORT
|
||||
value: "{{ .Values.HTTPContainerPort }}"
|
||||
{{- end }}
|
||||
- name: APPSMITH_ENABLE_EMBEDDED_DB
|
||||
value: "0"
|
||||
envFrom:
|
||||
|
|
|
|||
|
|
@ -316,3 +316,5 @@ applicationConfig:
|
|||
APPSMITH_ENCRYPTION_SALT: ""
|
||||
APPSMITH_CUSTOM_DOMAIN: ""
|
||||
APPSMITH_DISABLE_IFRAME_WIDGET_SANDBOX: "false"
|
||||
|
||||
#HTTPContainerPort: 8080
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user