Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test: Use deep.eq for comparing objects (#34513)

Browse Source 
The JSON string comparison is flaky because it depends on the order of
keys in serialized objects. We actually don't care for the order the
keys are serialized, just that the keys and values are as we want.

This PR should fix that.

[Slack
conversation](https://theappsmith.slack.com/archives/C0134BAVDB4/p1719409620659339).

/test table


<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9681276909>
> Commit: 3fa1746c580d700a3084d94166850acd18432d09
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9681276909&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Table`

<!-- end of auto-generated comment: Cypress test results  -->
This commit is contained in:
Shrikant Sharat Kandula 2024-06-26 21:16:29 +05:30 committed by GitHub
parent 57f86debae
commit 6f67dbd85e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Date_column_editing_1_spec.ts
View File

@ -60,20 +60,28 @@ describe(
);
agHelper.AssertElementAbsence(table._dateInputPopover);
agHelper.AssertElementAbsence(table._editCellEditor);
agHelper
.GetText(locators._textWidget, "text", 0)
.then(($textData) =>
expect($textData).to.eq(
`{"revenue":42600000,"imdb_id":"tt3228774","release_date":"2021-05-17"}`,
),
);
agHelper
.GetText(locators._textWidget, "text", 1)
.then(($textData) =>
expect($textData).to.eq(
`[{"index":0,"updatedFields":{"release_date":"2021-05-17"},"allFields":{"revenue":42600000,"imdb_id":"tt3228774","release_date":"2021-05-17"}}]`,
),
);
agHelper.GetText(locators._textWidget, "text", 0).then(($textData) =>
expect(JSON.parse($textData as string)).to.deep.eq({
revenue: 42600000,
imdb_id: "tt3228774",
release_date: "2021-05-17",
}),
);
agHelper.GetText(locators._textWidget, "text", 1).then(($textData) =>
expect(JSON.parse($textData as string)).to.deep.eq([
{
index: 0,
updatedFields: {
release_date: "2021-05-17",
},
allFields: {
revenue: 42600000,
imdb_id: "tt3228774",
release_date: "2021-05-17",
},
},
]),
);
agHelper
.GetText(locators._textWidget, "text", 2)
.then(($textData) => expect($textData).to.eq("[0]"));