Hide other header elements while showing the deploy button

This commit is contained in:
akash-codemonk 2021-01-06 09:38:18 +05:30 committed by hetunandu
parent 1e17c03478
commit 6e4cdb0f84
4 changed files with 28 additions and 5 deletions

View File

@ -56,7 +56,18 @@ describe("Onboarding", function() {
cy.openPropertyPane("tablewidget"); cy.openPropertyPane("tablewidget");
cy.closePropertyPane(); cy.closePropertyPane();
cy.PublishtheApp(); cy.get(".t--application-feedback-btn").should("not.be.visible");
// Publish
cy.window().then((window) => {
cy.stub(window, "open").callsFake((url) => {
window.location.href = Cypress.config().baseUrl + url.substring(1);
window.location.target = "_self";
});
});
cy.get(homePage.publishButton).click();
cy.wait("@publishApp");
cy.get(".t--continue-on-my-own").click(); cy.get(".t--continue-on-my-own").click();
}); });
}); });

View File

@ -1,4 +1,3 @@
import { setCurrentStep } from "actions/onboardingActions";
import { ReduxAction, ReduxActionTypes } from "./ReduxActionConstants"; import { ReduxAction, ReduxActionTypes } from "./ReduxActionConstants";
import { EventName } from "../utils/AnalyticsUtil"; import { EventName } from "../utils/AnalyticsUtil";
@ -11,6 +10,7 @@ export enum OnboardingStep {
ADD_WIDGET = 4, ADD_WIDGET = 4,
SUCCESSFUL_BINDING = 5, SUCCESSFUL_BINDING = 5,
DEPLOY = 6, DEPLOY = 6,
FINISH = 7,
} }
export type OnboardingTooltip = { export type OnboardingTooltip = {
@ -140,4 +140,13 @@ export const OnboardingConfig: Record<OnboardingStep, OnboardingStepConfig> = {
}, },
eventName: "ONBOARDING_DEPLOY", eventName: "ONBOARDING_DEPLOY",
}, },
// Final step
[OnboardingStep.FINISH]: {
setup: () => {
return [];
},
tooltip: {
title: "",
},
},
}; };

View File

@ -215,7 +215,7 @@ export const EditorHeader = (props: EditorHeaderProps) => {
/> />
</Link> </Link>
</HeaderSection> </HeaderSection>
<Boxed step={OnboardingStep.DEPLOY}> <Boxed step={OnboardingStep.FINISH}>
<HeaderSection flex-direction={"row"}> <HeaderSection flex-direction={"row"}>
{currentApplication ? ( {currentApplication ? (
<EditableTextWrapper <EditableTextWrapper
@ -244,7 +244,7 @@ export const EditorHeader = (props: EditorHeaderProps) => {
</HeaderSection> </HeaderSection>
</Boxed> </Boxed>
<HeaderSection> <HeaderSection>
<Boxed step={OnboardingStep.DEPLOY}> <Boxed step={OnboardingStep.FINISH}>
<SaveStatusContainer className={"t--save-status-container"}> <SaveStatusContainer className={"t--save-status-container"}>
{saveStatusIcon} {saveStatusIcon}
</SaveStatusContainer> </SaveStatusContainer>

View File

@ -118,7 +118,8 @@ function* listenForSuccessfullBinding() {
const widgetProperties = dataTree[selectedWidget.widgetName]; const widgetProperties = dataTree[selectedWidget.widgetName];
const dynamicBindingPathList = const dynamicBindingPathList =
dataTree[selectedWidget.widgetName].dynamicBindingPathList; dataTree[selectedWidget.widgetName].dynamicBindingPathList;
const hasBinding = !!dynamicBindingPathList.length; const hasBinding =
dynamicBindingPathList && !!dynamicBindingPathList.length;
if (hasBinding) { if (hasBinding) {
yield put(showTooltip(OnboardingStep.NONE)); yield put(showTooltip(OnboardingStep.NONE));
@ -261,6 +262,8 @@ function* listenForDeploySaga() {
yield take(ReduxActionTypes.PUBLISH_APPLICATION_SUCCESS); yield take(ReduxActionTypes.PUBLISH_APPLICATION_SUCCESS);
yield put(showTooltip(OnboardingStep.NONE)); yield put(showTooltip(OnboardingStep.NONE));
yield put(setCurrentStep(OnboardingStep.FINISH));
yield put({ yield put({
type: ReduxActionTypes.SHOW_ONBOARDING_COMPLETION_DIALOG, type: ReduxActionTypes.SHOW_ONBOARDING_COMPLETION_DIALOG,
payload: true, payload: true,