From 6abd5e2c0a8c57cfa4e8a001b3e8ba26472f6f47 Mon Sep 17 00:00:00 2001
From: Valera Melnikov <valera@appsmith.com>
Date: Fri, 13 Oct 2023 12:08:01 +0300
Subject: [PATCH] fix: auto label position (#28022)

## Description
Fix auto label position

Fixes #27975

#### Media

https://github.com/appsmithorg/appsmith/assets/11555074/bf6e4c8c-97db-4eab-8986-b4cd2de5bd0a

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
>
>
#### Test Plan
> Add Testsmith test cases links that relate to this PR
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag

#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed

(cherry picked from commit b42caa030823f47625098305565b3c68d4725895)
---
 app/client/src/widgets/WidgetUtils.test.ts | 7 +++++++
 app/client/src/widgets/WidgetUtils.ts      | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/app/client/src/widgets/WidgetUtils.test.ts b/app/client/src/widgets/WidgetUtils.test.ts
index d6a90203a8..aeec7138e3 100644
--- a/app/client/src/widgets/WidgetUtils.test.ts
+++ b/app/client/src/widgets/WidgetUtils.test.ts
@@ -26,6 +26,7 @@ import {
   isAutoHeightEnabledForWidgetWithLimits,
   getWidgetMaxAutoHeight,
   getWidgetMinAutoHeight,
+  isCompactMode,
 } from "./WidgetUtils";
 import {
   getCustomTextColor,
@@ -696,4 +697,10 @@ describe("Should Update Widget Height Automatically?", () => {
     const result = shouldUpdateWidgetHeightAutomatically(input, props);
     expect(result).toStrictEqual(expected);
   });
+  it("should return correct value for isCompactMode", () => {
+    const compactHeight = 40;
+    const unCompactHeight = 41;
+    expect(isCompactMode(compactHeight)).toBeTruthy();
+    expect(isCompactMode(unCompactHeight)).toBeFalsy();
+  });
 });
diff --git a/app/client/src/widgets/WidgetUtils.ts b/app/client/src/widgets/WidgetUtils.ts
index 31761b438a..8f60f05e20 100644
--- a/app/client/src/widgets/WidgetUtils.ts
+++ b/app/client/src/widgets/WidgetUtils.ts
@@ -921,7 +921,7 @@ const findReactInstanceProps = (domElement: any) => {
 
 export function isCompactMode(componentHeight: number) {
   return (
-    componentHeight <
+    componentHeight <=
     COMPACT_MODE_MIN_ROWS * GridDefaults.DEFAULT_GRID_ROW_HEIGHT
   );
 }