From 647bddd60ce4be693e3e5a2efd1f684a374ee4eb Mon Sep 17 00:00:00 2001 From: Hetu Nandu Date: Thu, 8 Jun 2023 10:02:23 +0530 Subject: [PATCH] fix: Removed duplicate flaky test (#24189) Remove tests that fail via jest but are tested on cypress --- .../GlobalHotKeys/GlobalHotKeys.test.tsx | 230 ------------------ 1 file changed, 230 deletions(-) diff --git a/app/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsx b/app/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsx index 9a6f763406..95c1a0b309 100644 --- a/app/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsx +++ b/app/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsx @@ -22,14 +22,12 @@ import { MockApplication, mockCreateCanvasWidget, mockGetCanvasWidgetDsl, - mockGetChildWidgets, mockGetWidgetEvalValues, MockPageDSL, useMockDsl, } from "test/testCommon"; import { MockCanvas } from "test/testMockedWidgets"; import { act, fireEvent, render, waitFor } from "test/testUtils"; -import { generateReactKey } from "utils/generators"; import * as widgetRenderUtils from "utils/widgetRenderUtils"; import MainContainer from "../MainContainer"; import GlobalHotKeys from "./GlobalHotKeys"; @@ -53,11 +51,6 @@ describe("Canvas Hot Keys", () => { const mockGetIsFetchingPage = jest.spyOn(utilities, "getIsFetchingPage"); const spyGetCanvasWidgetDsl = jest.spyOn(utilities, "getCanvasWidgetDsl"); - const spyGetChildWidgets = jest.spyOn(utilities, "getChildWidgets"); - const spyCreateCanvasWidget = jest.spyOn( - widgetRenderUtils, - "createCanvasWidget", - ); function UpdatedEditor({ dsl }: any) { useMockDsl(dsl); @@ -225,229 +218,6 @@ describe("Canvas Hot Keys", () => { expect(spyPaste).toHaveBeenCalled(); }); - // eslint-disable-next-line jest/no-disabled-tests - it.skip("Cmd + A - select all widgets inside last selected container", async () => { - const containerId = generateReactKey(); - const canvasId = generateReactKey(); - const children: any = buildChildren([ - { type: "CHECKBOX_WIDGET", parentId: canvasId }, - { type: "SWITCH_WIDGET", parentId: canvasId }, - { type: "BUTTON_WIDGET", parentId: canvasId }, - ]); - const canvasWidget = buildChildren([ - { - type: "CANVAS_WIDGET", - parentId: containerId, - children, - widgetId: canvasId, - }, - ]); - const containerChildren: any = buildChildren([ - { - type: "CONTAINER_WIDGET", - children: canvasWidget, - widgetId: containerId, - parentId: "0", - }, - { type: "CHART_WIDGET", parentId: "0" }, - ]); - const dsl: any = widgetCanvasFactory.build({ - children: containerChildren, - }); - spyGetCanvasWidgetDsl.mockImplementation(mockGetCanvasWidgetDsl); - mockGetIsFetchingPage.mockImplementation(() => false); - const spyWidgetSelection = jest.spyOn( - widgetSelectionsActions, - "selectWidgetInitAction", - ); - - const component = render( - - - { - return { x: 0, y: 0 }; - }} - > - - - - , - { initialState: store.getState(), sagasToRun: sagasToRunForTests }, - ); - const canvasWidgets = component.queryAllByTestId("test-widget"); - expect(canvasWidgets.length).toBe(5); - if (canvasWidgets[0].firstChild) { - fireEvent.mouseOver(canvasWidgets[0].firstChild); - fireEvent.click(canvasWidgets[0].firstChild); - } - expect(spyWidgetSelection).toHaveBeenCalledWith( - SelectionRequestType.One, - ["tabsWidgetId"], - undefined, - ); - spyWidgetSelection.mockClear(); - - dispatchTestKeyboardEventWithCode( - component.container, - "keydown", - "A", - 65, - false, - true, - ); - - expect(spyWidgetSelection).toHaveBeenCalledWith( - SelectionRequestType.One, - ["tabsWidgetId"], - undefined, - undefined, - ); - spyWidgetSelection.mockClear(); - }); - // eslint-disable-next-line jest/no-disabled-tests - it.skip("Cmd + A - select all widgets inside a form", async () => { - spyGetChildWidgets.mockImplementation(mockGetChildWidgets); - const children: any = buildChildren([ - { type: "FORM_WIDGET", parentId: MAIN_CONTAINER_WIDGET_ID }, - ]); - const dsl: any = widgetCanvasFactory.build({ - children, - }); - - spyGetCanvasWidgetDsl.mockImplementation(mockGetCanvasWidgetDsl); - mockGetIsFetchingPage.mockImplementation(() => false); - - const component = render( - - - { - return { x: 0, y: 0 }; - }} - > - - - - , - { initialState: store.getState(), sagasToRun: sagasToRunForTests }, - ); - const propPane = component.queryByTestId("t--propertypane"); - expect(propPane).toBeNull(); - const canvasWidgets = component.queryAllByTestId("test-widget"); - expect(canvasWidgets.length).toBe(4); - if (canvasWidgets[0].firstChild) { - fireEvent.mouseOver(canvasWidgets[0].firstChild); - fireEvent.click(canvasWidgets[0].firstChild); - } - - dispatchTestKeyboardEventWithCode( - component.container, - "keydown", - "A", - 65, - false, - true, - ); - const selectedWidgets = component.queryAllByTestId("t--selected"); - expect(selectedWidgets.length).toBe(3); - }); - // eslint-disable-next-line jest/no-disabled-tests - it.skip("Cmd + A - select all widgets inside a list", async () => { - const listId = generateReactKey(); - const containerId = generateReactKey(); - const canvasId = generateReactKey(); - const listCanvasId = generateReactKey(); - const children: any = buildChildren([ - { type: "CHECKBOX_WIDGET", parentId: canvasId }, - { type: "SWITCH_WIDGET", parentId: canvasId }, - { type: "BUTTON_WIDGET", parentId: canvasId }, - ]); - const canvasWidget = buildChildren([ - { - type: "CANVAS_WIDGET", - parentId: containerId, - children, - widgetId: canvasId, - bottomRow: 20, - }, - ]); - const containerChildren: any = buildChildren([ - { - type: "CONTAINER_WIDGET", - children: canvasWidget, - widgetId: containerId, - parentId: listCanvasId, - dropDisabled: true, - bottomRow: 4, - }, - ]); - const listCanvasChildren: any = buildChildren([ - { - type: "CANVAS_WIDGET", - children: containerChildren, - widgetId: listCanvasId, - dropDisabled: true, - parentId: listId, - bottomRow: 20, - }, - ]); - const listChildren: any = buildChildren([ - { - type: "LIST_WIDGET", - children: listCanvasChildren, - widgetId: listId, - parentId: "0", - }, - ]); - const dsl: any = widgetCanvasFactory.build({ - children: listChildren, - }); - spyGetCanvasWidgetDsl.mockImplementation(mockGetCanvasWidgetDsl); - mockGetIsFetchingPage.mockImplementation(() => false); - spyGetChildWidgets.mockImplementation(mockGetChildWidgets); - spyCreateCanvasWidget.mockImplementation(mockCreateCanvasWidget); - - const component = render( - - - { - return { x: 0, y: 0 }; - }} - > - - - - , - { initialState: store.getState(), sagasToRun: sagasToRunForTests }, - ); - const propPane = component.queryByTestId("t--propertypane"); - expect(propPane).toBeNull(); - const canvasWidgets = component.queryAllByTestId("test-widget"); - - if (canvasWidgets[0].firstChild) { - fireEvent.mouseOver(canvasWidgets[0].firstChild); - fireEvent.click(canvasWidgets[0].firstChild); - } - - dispatchTestKeyboardEventWithCode( - component.container, - "keydown", - "A", - 65, - false, - true, - ); - const selectedWidgets = component.queryAllByTestId("t--selected"); - expect(selectedWidgets.length).toBe(3); - }); }); afterAll(() => jest.resetModules());