Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Removed duplicate flaky test (#24189)

Browse Source 
Remove tests that fail via jest but are tested on cypress
This commit is contained in:
Hetu Nandu 2023-06-08 10:02:23 +05:30 committed by GitHub
parent 94ebacdf80
commit 647bddd60c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 230 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

230
app/client/src/pages/Editor/GlobalHotKeys/GlobalHotKeys.test.tsx
View File

@ -22,14 +22,12 @@ import {
MockApplication,
mockCreateCanvasWidget,
mockGetCanvasWidgetDsl,
mockGetChildWidgets,
mockGetWidgetEvalValues,
MockPageDSL,
useMockDsl,
} from "test/testCommon";
import { MockCanvas } from "test/testMockedWidgets";
import { act, fireEvent, render, waitFor } from "test/testUtils";
import { generateReactKey } from "utils/generators";
import * as widgetRenderUtils from "utils/widgetRenderUtils";
import MainContainer from "../MainContainer";
import GlobalHotKeys from "./GlobalHotKeys";
@ -53,11 +51,6 @@ describe("Canvas Hot Keys", () => {
const mockGetIsFetchingPage = jest.spyOn(utilities, "getIsFetchingPage");
const spyGetCanvasWidgetDsl = jest.spyOn(utilities, "getCanvasWidgetDsl");
const spyGetChildWidgets = jest.spyOn(utilities, "getChildWidgets");
const spyCreateCanvasWidget = jest.spyOn(
widgetRenderUtils,
"createCanvasWidget",
);
function UpdatedEditor({ dsl }: any) {
useMockDsl(dsl);
@ -225,229 +218,6 @@ describe("Canvas Hot Keys", () => {
expect(spyPaste).toHaveBeenCalled();
});
// eslint-disable-next-line jest/no-disabled-tests
it.skip("Cmd + A - select all widgets inside last selected container", async () => {
const containerId = generateReactKey();
const canvasId = generateReactKey();
const children: any = buildChildren([
{ type: "CHECKBOX_WIDGET", parentId: canvasId },
{ type: "SWITCH_WIDGET", parentId: canvasId },
{ type: "BUTTON_WIDGET", parentId: canvasId },
]);
const canvasWidget = buildChildren([
{
type: "CANVAS_WIDGET",
parentId: containerId,
children,
widgetId: canvasId,
},
]);
const containerChildren: any = buildChildren([
{
type: "CONTAINER_WIDGET",
children: canvasWidget,
widgetId: containerId,
parentId: "0",
},
{ type: "CHART_WIDGET", parentId: "0" },
]);
const dsl: any = widgetCanvasFactory.build({
children: containerChildren,
});
spyGetCanvasWidgetDsl.mockImplementation(mockGetCanvasWidgetDsl);
mockGetIsFetchingPage.mockImplementation(() => false);
const spyWidgetSelection = jest.spyOn(
widgetSelectionsActions,
"selectWidgetInitAction",
);
const component = render(
<MemoryRouter
initialEntries={["/app/applicationSlug/pageSlug-page_id/edit"]}
>
<MockApplication>
<GlobalHotKeys
getMousePosition={() => {
return { x: 0, y: 0 };
}}
>
<UpdatedEditor dsl={dsl} />
</GlobalHotKeys>
</MockApplication>
</MemoryRouter>,
{ initialState: store.getState(), sagasToRun: sagasToRunForTests },
);
const canvasWidgets = component.queryAllByTestId("test-widget");
expect(canvasWidgets.length).toBe(5);
if (canvasWidgets[0].firstChild) {
fireEvent.mouseOver(canvasWidgets[0].firstChild);
fireEvent.click(canvasWidgets[0].firstChild);
}
expect(spyWidgetSelection).toHaveBeenCalledWith(
SelectionRequestType.One,
["tabsWidgetId"],
undefined,
);
spyWidgetSelection.mockClear();
dispatchTestKeyboardEventWithCode(
component.container,
"keydown",
"A",
65,
false,
true,
);
expect(spyWidgetSelection).toHaveBeenCalledWith(
SelectionRequestType.One,
["tabsWidgetId"],
undefined,
undefined,
);
spyWidgetSelection.mockClear();
});
// eslint-disable-next-line jest/no-disabled-tests
it.skip("Cmd + A - select all widgets inside a form", async () => {
spyGetChildWidgets.mockImplementation(mockGetChildWidgets);
const children: any = buildChildren([
{ type: "FORM_WIDGET", parentId: MAIN_CONTAINER_WIDGET_ID },
]);
const dsl: any = widgetCanvasFactory.build({
children,
});
spyGetCanvasWidgetDsl.mockImplementation(mockGetCanvasWidgetDsl);
mockGetIsFetchingPage.mockImplementation(() => false);
const component = render(
<MemoryRouter
initialEntries={["/app/applicationSlug/pageSlug-page_id/edit"]}
>
<MockApplication>
<GlobalHotKeys
getMousePosition={() => {
return { x: 0, y: 0 };
}}
>
<UpdatedEditor dsl={dsl} />
</GlobalHotKeys>
</MockApplication>
</MemoryRouter>,
{ initialState: store.getState(), sagasToRun: sagasToRunForTests },
);
const propPane = component.queryByTestId("t--propertypane");
expect(propPane).toBeNull();
const canvasWidgets = component.queryAllByTestId("test-widget");
expect(canvasWidgets.length).toBe(4);
if (canvasWidgets[0].firstChild) {
fireEvent.mouseOver(canvasWidgets[0].firstChild);
fireEvent.click(canvasWidgets[0].firstChild);
}
dispatchTestKeyboardEventWithCode(
component.container,
"keydown",
"A",
65,
false,
true,
);
const selectedWidgets = component.queryAllByTestId("t--selected");
expect(selectedWidgets.length).toBe(3);
});
// eslint-disable-next-line jest/no-disabled-tests
it.skip("Cmd + A - select all widgets inside a list", async () => {
const listId = generateReactKey();
const containerId = generateReactKey();
const canvasId = generateReactKey();
const listCanvasId = generateReactKey();
const children: any = buildChildren([
{ type: "CHECKBOX_WIDGET", parentId: canvasId },
{ type: "SWITCH_WIDGET", parentId: canvasId },
{ type: "BUTTON_WIDGET", parentId: canvasId },
]);
const canvasWidget = buildChildren([
{
type: "CANVAS_WIDGET",
parentId: containerId,
children,
widgetId: canvasId,
bottomRow: 20,
},
]);
const containerChildren: any = buildChildren([
{
type: "CONTAINER_WIDGET",
children: canvasWidget,
widgetId: containerId,
parentId: listCanvasId,
dropDisabled: true,
bottomRow: 4,
},
]);
const listCanvasChildren: any = buildChildren([
{
type: "CANVAS_WIDGET",
children: containerChildren,
widgetId: listCanvasId,
dropDisabled: true,
parentId: listId,
bottomRow: 20,
},
]);
const listChildren: any = buildChildren([
{
type: "LIST_WIDGET",
children: listCanvasChildren,
widgetId: listId,
parentId: "0",
},
]);
const dsl: any = widgetCanvasFactory.build({
children: listChildren,
});
spyGetCanvasWidgetDsl.mockImplementation(mockGetCanvasWidgetDsl);
mockGetIsFetchingPage.mockImplementation(() => false);
spyGetChildWidgets.mockImplementation(mockGetChildWidgets);
spyCreateCanvasWidget.mockImplementation(mockCreateCanvasWidget);
const component = render(
<MemoryRouter
initialEntries={["/app/applicationSlug/pageSlug-page_id/edit"]}
>
<MockApplication>
<GlobalHotKeys
getMousePosition={() => {
return { x: 0, y: 0 };
}}
>
<UpdatedEditor dsl={dsl} />
</GlobalHotKeys>
</MockApplication>
</MemoryRouter>,
{ initialState: store.getState(), sagasToRun: sagasToRunForTests },
);
const propPane = component.queryByTestId("t--propertypane");
expect(propPane).toBeNull();
const canvasWidgets = component.queryAllByTestId("test-widget");
if (canvasWidgets[0].firstChild) {
fireEvent.mouseOver(canvasWidgets[0].firstChild);
fireEvent.click(canvasWidgets[0].firstChild);
}
dispatchTestKeyboardEventWithCode(
component.container,
"keydown",
"A",
65,
false,
true,
);
const selectedWidgets = component.queryAllByTestId("t--selected");
expect(selectedWidgets.length).toBe(3);
});
});
afterAll(() => jest.resetModules());