From 62756dd89caf7b97d0aa3499d067b10017ce69df Mon Sep 17 00:00:00 2001 From: Rishabh Kashyap Date: Fri, 25 Nov 2022 11:21:55 +0530 Subject: [PATCH] fix: error message for input widget updated for when the default value is more than the max chars allowed (#17885) * bug fixed and test case written * removed the test case * changes to fix ui-test set status in the PR --- .../ClientSideTests/Widgets/Input/Input_MaxChar_spec.js | 4 +++- .../Widgets/JSONForm/JSONForm_FieldProperties_spec.js | 4 +++- app/client/src/ce/constants/messages.ts | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_MaxChar_spec.js b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_MaxChar_spec.js index 6440f83395..175fa58ea1 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_MaxChar_spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/Input/Input_MaxChar_spec.js @@ -18,7 +18,9 @@ describe("Input Widget Max Char Functionality", function() { it("Text Input maxChar shows error if defaultText longer", () => { cy.get(widgetsPage.innertext).click(); cy.get(".bp3-popover-content").should(($x) => { - expect($x).contain("Default text length must be less than 5 characters"); + expect($x).contain( + "Default text length must be less than or equal to 5 characters", + ); }); }); diff --git a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FieldProperties_spec.js b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FieldProperties_spec.js index 5c331428b7..6a776e0d47 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FieldProperties_spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Widgets/JSONForm/JSONForm_FieldProperties_spec.js @@ -38,7 +38,9 @@ describe("Text Field Property Control", () => { cy.testJsontext("maxchars", 5); cy.get(`${fieldPrefix}-name input`).click(); cy.get(".bp3-popover-content").should(($x) => { - expect($x).contain("Default text length must be less than 5 characters"); + expect($x).contain( + "Default text length must be less than or equal to 5 characters", + ); }); cy.testJsontext("maxchars", ""); }); diff --git a/app/client/src/ce/constants/messages.ts b/app/client/src/ce/constants/messages.ts index cb3a51aa44..41f535b811 100644 --- a/app/client/src/ce/constants/messages.ts +++ b/app/client/src/ce/constants/messages.ts @@ -28,7 +28,7 @@ export const ERROR_EMPTY_APPLICATION_NAME = () => export const API_PATH_START_WITH_SLASH_ERROR = () => `Path cannot start with /`; export const FIELD_REQUIRED_ERROR = () => `This field is required`; export const INPUT_DEFAULT_TEXT_MAX_CHAR_ERROR = (max: number) => - `Default text length must be less than ${max} characters`; + `Default text length must be less than or equal to ${max} characters`; export const INPUT_TEXT_MAX_CHAR_ERROR = (max: number) => `Input text length must be less than ${max} characters`; export const INPUT_DEFAULT_TEXT_MAX_NUM_ERROR = () =>