From 61bdac3a777b144482af201c19d13b0058494f62 Mon Sep 17 00:00:00 2001 From: Rishabh Rathod Date: Mon, 22 May 2023 11:40:59 +0530 Subject: [PATCH] fix: API.run undefined error (#23518) ## Description After evaluating the variable mutation changes set the evalContext to async evaluation so that API or query could execute as expected. #### PR fixes following issue(s) Fixes https://github.com/appsmithorg/appsmith/issues/23519 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- app/client/src/workers/Evaluation/evalTreeWithChanges.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/app/client/src/workers/Evaluation/evalTreeWithChanges.ts b/app/client/src/workers/Evaluation/evalTreeWithChanges.ts index dd38fd4c2d..f5293cec4d 100644 --- a/app/client/src/workers/Evaluation/evalTreeWithChanges.ts +++ b/app/client/src/workers/Evaluation/evalTreeWithChanges.ts @@ -13,6 +13,7 @@ import { MessageType, sendMessage } from "utils/MessageUtil"; import { MAIN_THREAD_ACTION } from "@appsmith/workers/Evaluation/evalWorkerActions"; import type { UpdateDataTreeMessageData } from "sagas/EvalWorkerActionSagas"; import type { JSUpdate } from "utils/JSPaneUtils"; +import { setEvalContext } from "./evaluate"; export function evalTreeWithChanges(updatedValuePaths: string[][]) { let evalOrder: string[] = []; @@ -44,6 +45,13 @@ export function evalTreeWithChanges(updatedValuePaths: string[][]) { dataTreeEvaluator.oldConfigTree, unEvalUpdates, ); + + setEvalContext({ + dataTree: dataTreeEvaluator.evalTree, + isDataField: false, + isTriggerBased: true, + }); + dataTree = makeEntityConfigsAsObjProperties(dataTreeEvaluator.evalTree, { evalProps: dataTreeEvaluator.evalProps, });