Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: 7630 fixing where clause add delete row (#7968)

Browse Source 
* Added new row addition action for form value changes

* Added comments

* Added special handling for where clause rows
This commit is contained in:
Ayush Pahwa 2021-09-30 15:10:40 +05:30 committed by GitHub
parent cf3cdced07
commit 6023bb10e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
app/client/src/sagas/SaaSPaneSagas.ts
View File

@ -22,6 +22,7 @@ import { SAAS_EDITOR_FORM } from "constants/forms";
import { getFormData } from "selectors/formSelectors"; import { getFormData } from "selectors/formSelectors";
import { setActionProperty } from "actions/pluginActionActions"; import { setActionProperty } from "actions/pluginActionActions";
import { autofill } from "redux-form"; import { autofill } from "redux-form";
import { get } from "lodash";
function* handleDatasourceCreatedSaga(actionPayload: ReduxAction<Datasource>) { function* handleDatasourceCreatedSaga(actionPayload: ReduxAction<Datasource>) {
const plugin = yield select(getPlugin, actionPayload.payload.pluginId); const plugin = yield select(getPlugin, actionPayload.payload.pluginId);
@ -64,7 +65,6 @@ function* formValueChangeSaga(
if (field === "dynamicBindingPathList" || field === "name") return; if (field === "dynamicBindingPathList" || field === "name") return;
if (form !== SAAS_EDITOR_FORM) return; if (form !== SAAS_EDITOR_FORM) return;
const { values } = yield select(getFormData, SAAS_EDITOR_FORM); const { values } = yield select(getFormData, SAAS_EDITOR_FORM);
if (field === "datasource.id") { if (field === "datasource.id") {
const datasource = yield select(getDatasource, actionPayload.payload); const datasource = yield select(getDatasource, actionPayload.payload);
@ -83,13 +83,29 @@ function* formValueChangeSaga(
return; return;
} }
yield put( // Special handling of the case when the where clause row is added or removed
setActionProperty({ if (
actionId: values.id, actionPayload.type === ReduxFormActionTypes.ARRAY_REMOVE ||
propertyName: field, actionPayload.type === ReduxFormActionTypes.ARRAY_PUSH
value: actionPayload.payload, ) {
}), // Sending only the value for the where clause rather than the payload
); const value = get(values, field);
yield put(
setActionProperty({
actionId: values.id,
propertyName: field,
value,
}),
);
} else {
yield put(
setActionProperty({
actionId: values.id,
propertyName: field,
value: actionPayload.payload,
}),
);
}
} }
export default function* root() { export default function* root() {