From 5b41dbae15de081831fb05affac73719913c03fa Mon Sep 17 00:00:00 2001 From: arunvjn <32433245+arunvjn@users.noreply.github.com> Date: Tue, 19 Sep 2023 16:49:22 +0530 Subject: [PATCH] fix: Remove duplicate debugger logs for showModal function (#27382) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Remove duplicate debugger logs for showModal function > > Links to Notion, Figma or any other documents that might be relevant to the PR > > #### PR fixes following issue(s) Fixes #24883 > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change - Bug fix (non-breaking change which fixes an issue) > > ## Testing > #### How Has This Been Tested? - [x] Manual > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- app/client/src/sagas/ActionExecution/ModalSagas.ts | 2 +- app/client/src/sagas/ModalSagas.ts | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/app/client/src/sagas/ActionExecution/ModalSagas.ts b/app/client/src/sagas/ActionExecution/ModalSagas.ts index 174e42ba2c..9394e65ed5 100644 --- a/app/client/src/sagas/ActionExecution/ModalSagas.ts +++ b/app/client/src/sagas/ActionExecution/ModalSagas.ts @@ -19,7 +19,7 @@ export function* openModalSaga(action: TShowModalDescription) { } yield put(action); AppsmithConsole.info({ - text: `openModal(${modalName}) was triggered`, + text: `showModal('${modalName ?? ""}') was triggered`, }); } diff --git a/app/client/src/sagas/ModalSagas.ts b/app/client/src/sagas/ModalSagas.ts index 3bb0ca2d49..c391b03a09 100644 --- a/app/client/src/sagas/ModalSagas.ts +++ b/app/client/src/sagas/ModalSagas.ts @@ -38,8 +38,6 @@ import { updateWidgetMetaPropAndEval } from "actions/metaActions"; import { focusWidget, showModal } from "actions/widgetActions"; import log from "loglevel"; import { flatten } from "lodash"; -import AppsmithConsole from "utils/AppsmithConsole"; - import WidgetFactory from "WidgetProvider/factory"; import type { WidgetProps } from "widgets/BaseWidget"; import { selectWidgetInitAction } from "actions/widgetSelectionActions"; @@ -119,12 +117,6 @@ export function* showModalByNameSaga( widget.widgetName === action.payload.modalName, ); if (modal) { - AppsmithConsole.info({ - text: action.payload.modalName - ? `showModal('${action.payload.modalName}') was triggered` - : `showModal() was triggered`, - }); - yield put(showModal(modal.widgetId)); } }