From 5a98e8f4bae0eb6e83eba77ba63a6f32d4419a0f Mon Sep 17 00:00:00 2001 From: Favour Ohanekwu Date: Mon, 2 Jan 2023 11:39:19 +0100 Subject: [PATCH] fix: EE client-build failure (#19411) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Import Appstate from "@appsmith/ " instead of "ce/" Fixes # (issue) > if no issue exists, please create an issue and ask the maintainers about this first Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video ## Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - This change requires a documentation update ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test Co-authored-by: Ankita Kinger --- app/client/src/workers/Evaluation/JSObject/utils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/client/src/workers/Evaluation/JSObject/utils.ts b/app/client/src/workers/Evaluation/JSObject/utils.ts index 1db35c0abf..7be11c15cb 100644 --- a/app/client/src/workers/Evaluation/JSObject/utils.ts +++ b/app/client/src/workers/Evaluation/JSObject/utils.ts @@ -8,7 +8,7 @@ import { ParsedBody, ParsedJSSubAction } from "utils/JSPaneUtils"; import { unset, set, get } from "lodash"; import { BatchedJSExecutionData } from "reducers/entityReducers/jsActionsReducer"; import { select } from "redux-saga/effects"; -import { AppState } from "ce/reducers"; +import { AppState } from "@appsmith/reducers"; import { JSAction } from "entities/JSCollection"; import { getJSFunctionFromName } from "selectors/entitiesSelector"; import { isJSAction } from "@appsmith/workers/Evaluation/evaluationUtils"; @@ -264,6 +264,7 @@ export function* sortJSExecutionDataByCollectionId( const jsAction: JSAction | undefined = yield select((state: AppState) => getJSFunctionFromName(state, jsfuncFullName), ); + if (jsAction && jsAction.collectionId) { if (sortedData[jsAction.collectionId]) { sortedData[jsAction.collectionId].push({