From 5996f74b730dfe4f163c8df0d526bc4d7df0a116 Mon Sep 17 00:00:00 2001 From: Rahul Barwal Date: Fri, 13 Sep 2024 14:43:23 +0530 Subject: [PATCH] test: fix failing table filter spec by rearranging steps. (#36303) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description In the spec, feature flag intercept is interfering with navigating back to editor flow. Since we need FF in the editor, this PR rearranges these steps. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Table" ### :mag: Cypress test results > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: > Commit: c7de064cd6c262f969270be226a135371985646e > Workflow: `PR Automation test suite` > Tags: `@tag.Table` > Spec: `` >
Fri, 13 Sep 2024 08:40:08 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **Bug Fixes** - Improved test flow for the Table V2 component by repositioning navigation actions, enhancing clarity and context. - **Chores** - Updated the configuration for limited tests to focus on the Table V2 widget's filtering functionality instead of template-related tests. --- .../ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts index 2c529e35fd..142401c067 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter1_1_Spec.ts @@ -143,10 +143,10 @@ describe( }); it("11. Verify table search includes label and value for table with select column type", () => { + deployMode.NavigateBacktoEditor(); // This flag is turned on to allow the label show in the table select cell content // when this feature is turned on fully, this flag will be removed featureFlagIntercept({ release_table_cell_label_value_enabled: true }); - deployMode.NavigateBacktoEditor(); EditorNavigation.SelectEntityByName("Table1", EntityType.Widget); propPane.EnterJSContext("Table data", demoTableDataForSelect);