Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test: Really empty DSL (#34510)

Browse Source 
Part of #33724, and extension to #34405.

This file's contents are used to call the endpoint:

```
/layouts/{layoutId}/pages/{pageId}?applicationId={applicationId}
```

But this endpoint accepts request payload as `LayoutUpdateDTO`, which
only has one single field, `dsl`, and nothing else.

But the way we use this JSON, is that we're sending the body as this:

```json
{
  "widgetName": "MainContainer",
  "backgroundColor": "none",
  "rightColumn": 1296,
  "snapColumns": 64,
  "detachFromLayout": true,
  "widgetId": "0",
  "topRow": 0,
  "bottomRow": 440,
  "containerStyle": "none",
  "snapRows": 125,
  "parentRowSpace": 1,
  "type": "CANVAS_WIDGET",
  "canExtend": true,
  "version": 47,
  "minHeight": 420,
  "parentColumnSpace": 1,
  "dynamicBindingPathList": [],
  "leftColumn": 0,
  "children": []
}
```

Not as this:
```json
{
  "dsl": {
    "widgetName": "MainContainer",
    "backgroundColor": "none",
    "rightColumn": 1296,
    "snapColumns": 64,
    "detachFromLayout": true,
    "widgetId": "0",
    "topRow": 0,
    "bottomRow": 440,
    "containerStyle": "none",
    "snapRows": 125,
    "parentRowSpace": 1,
    "type": "CANVAS_WIDGET",
    "canExtend": true,
    "version": 47,
    "minHeight": 420,
    "parentColumnSpace": 1,
    "dynamicBindingPathList": [],
    "leftColumn": 0,
    "children": []
  }
}
```

Which means that we aren't sending anything useful.


/test widget ide

<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9680215500>
> Commit: 8ede3e707c0487cdeda62b166487f093f1bcab78
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9680215500&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.IDE`

<!-- end of auto-generated comment: Cypress test results  -->
This commit is contained in:
Shrikant Sharat Kandula 2024-06-26 20:01:30 +05:30 committed by GitHub
parent e63a2a3361
commit 57f86debae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
app/client/cypress/fixtures/emptyDSL.json
View File

@ -1,25 +1 @@
{
"widgetName": "MainContainer",
"backgroundColor": "none",
"rightColumn": 1296,
"snapColumns": 64,
"detachFromLayout": true,
"widgetId": "0",
"topRow": 0,
"bottomRow": 440,
"containerStyle": "none",
"snapRows": 125,
"parentRowSpace": 1,
"type": "CANVAS_WIDGET",
"canExtend": true,
"version": 47,
"minHeight": 420,
"parentColumnSpace": 1,
"dynamicBindingPathList": [
],
"leftColumn": 0,
"children": [
]
}
{}