From 57a62f3ea120016721de014ab2f91a13e377cbd3 Mon Sep 17 00:00:00 2001 From: Valera Melnikov Date: Tue, 4 Jun 2024 12:28:29 +0300 Subject: [PATCH] fix: make url selectable (#33952) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description 1. Make url in page settings selectable. 2. Make DataSourceEditor selectable. Fixes [#33849](https://github.com/appsmithorg/appsmith/issues/33849) ## Automation /ok-to-test tags="@tag.IDE" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: deb311174f011191928744e0f440ab3ffe1deb09 > Cypress dashboard url: Click here! ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **Style** - Updated text selection behavior in various components to improve user interaction by adding the `select-text` class. - **Chores** - Reordered imports in the Cypress local setup script for better code organization. --- app/client/cypress/scripts/cypress-local-setup.js | 2 +- .../pages/Editor/AppSettingsPane/AppSettings/PageSettings.tsx | 2 +- app/client/src/pages/Editor/DataSourceEditor/JSONtoForm.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/client/cypress/scripts/cypress-local-setup.js b/app/client/cypress/scripts/cypress-local-setup.js index 384b1bdc62..35d45d927c 100644 --- a/app/client/cypress/scripts/cypress-local-setup.js +++ b/app/client/cypress/scripts/cypress-local-setup.js @@ -1,5 +1,5 @@ const { execSync } = require("child_process"); -const { readFileSync, existsSync, writeFileSync } = require("fs"); +const { existsSync, readFileSync, writeFileSync } = require("fs"); const path = require("path"); const prompt = require("prompt-sync")(); diff --git a/app/client/src/pages/Editor/AppSettingsPane/AppSettings/PageSettings.tsx b/app/client/src/pages/Editor/AppSettingsPane/AppSettings/PageSettings.tsx index cb1bfcad44..e721f2d23b 100644 --- a/app/client/src/pages/Editor/AppSettingsPane/AppSettings/PageSettings.tsx +++ b/app/client/src/pages/Editor/AppSettingsPane/AppSettings/PageSettings.tsx @@ -253,7 +253,7 @@ function PageSettings(props: { page: Page }) { {!appNeedsUpdate && ( { navigator.clipboard.writeText( location.protocol + diff --git a/app/client/src/pages/Editor/DataSourceEditor/JSONtoForm.tsx b/app/client/src/pages/Editor/DataSourceEditor/JSONtoForm.tsx index 579993ea84..2f4c939f4e 100644 --- a/app/client/src/pages/Editor/DataSourceEditor/JSONtoForm.tsx +++ b/app/client/src/pages/Editor/DataSourceEditor/JSONtoForm.tsx @@ -50,7 +50,7 @@ export class JSONtoForm< renderForm = (formContent: any) => { return ( // - + {formContent}