Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

chore: Refactor API for hiding logs (#32358)

Browse Source 
Sorry for quickly changing the signature(s) of this.

1. The generic method in the super class just wasn't working well. The
generic return type needs to be set explicitly in some places, and is
inferred in some, and is just too volatile. So we replicate the method
definition in both the subclasses for better API usage code.
2. The field already has a getter with Lombok, I didn't need to write a
new one. 🤦
This commit is contained in:
Shrikant Sharat Kandula 2024-04-03 13:08:29 +05:30 committed by GitHub
parent 48685e633a
commit 5767501060
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/BaseException.java vendored
View File

@ -11,7 +11,7 @@ public abstract class BaseException extends RuntimeException {
private Map<String, String> contextMap;
private boolean hideStackTraceInLogs = false;
protected boolean hideStackTraceInLogs = false;
public BaseException(String message) {
super(message);
@ -38,14 +38,4 @@ public abstract class BaseException extends RuntimeException {
public abstract String getDownstreamErrorCode();
public abstract String getErrorType();
@SuppressWarnings("unchecked")
public <T extends BaseException> T hideStackTraceInLogs() {
hideStackTraceInLogs = true;
return (T) this;
}
public boolean shouldHideStackTraceInLogs() {
return hideStackTraceInLogs;
}
}

5
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/exceptions/pluginExceptions/AppsmithPluginException.java vendored
View File

@ -60,4 +60,9 @@ public class AppsmithPluginException extends BaseException {
? AppsmithPluginErrorCode.GENERIC_PLUGIN_ERROR.getCode()
: this.error.getAppErrorCode();
}
public AppsmithPluginException hideStackTraceInLogs() {
hideStackTraceInLogs = true;
return this;
}
}

5
app/server/appsmith-server/src/main/java/com/appsmith/server/exceptions/AppsmithException.java
View File

@ -63,4 +63,9 @@ public class AppsmithException extends BaseException {
public String getReferenceDoc() {
return this.error.getReferenceDoc();
}
public AppsmithException hideStackTraceInLogs() {
hideStackTraceInLogs = true;
return this;
}
}

2
app/server/appsmith-server/src/main/java/com/appsmith/server/exceptions/GlobalExceptionHandler.java
View File

@ -67,7 +67,7 @@ public class GlobalExceptionHandler {
}
private void doLog(Throwable error) {
if (error instanceof BaseException baseException && baseException.shouldHideStackTraceInLogs()) {
if (error instanceof BaseException baseException && baseException.isHideStackTraceInLogs()) {
log.error(baseException.getClass().getSimpleName() + ": " + baseException.getMessage());
} else {
log.error("", error);