diff --git a/contributions/CodeContributionsGuidelines.md b/contributions/CodeContributionsGuidelines.md index 9309eaf516..4f2cd0e8ae 100644 --- a/contributions/CodeContributionsGuidelines.md +++ b/contributions/CodeContributionsGuidelines.md @@ -24,12 +24,13 @@ We use [Github Flow](https://guides.github.com/introduction/flow/index.html), so 1. Fork the repo and create a new branch from the `release` branch. 2. Branches are named as `fix/fix-name` or `feature/feature-name` 3. Please add tests for your changes. Client-side changes require Cypress/Jest tests while server-side changes require JUnit tests. -4. Once you are confident in your code changes, create a pull request in your fork to the release branch in the appsmithorg/appsmith base repository. -5. If you've changed any APIs, please call this out in the pull request and ensure backward compatibility. -6. Link the issue of the base repository in your Pull request description. [Guide](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) -7. When you raise a pull request, tag the maintainer you are collaborating with to start the build process. -8. If changes are requested, work on them, commit them back, and tag the reviewer again. -9. Once all changes have been approved by the reviewer and the CI has run successfully, your PR will be merged into the base branch. Congratulations! +4. If you are adding new cypress tests, add test path to `limited-tests.txt` +5. Once you are confident in your code changes, create a pull request in your fork to the release branch in the appsmithorg/appsmith base repository. +6. If you've changed any APIs, please call this out in the pull request and ensure backward compatibility. +7. Link the issue of the base repository in your Pull request description. [Guide](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue) +8. When you raise a pull request, tag the maintainer you are collaborating with to start the build process. +9. If changes are requested, work on them, commit them back, and tag the reviewer again. +10. Once all changes have been approved by the reviewer and the CI has run successfully, your PR will be merged into the base branch. Congratulations! ### 🏡 Setup for local development