fix: replacing onInteractOutside with onPointerDownOutside (#24830)
## Description While switching branches, the ellipsis (more) button is unresponsive for Firefox. It is working fine on Chrome. This PR fixes the issue. The underlying issue can be pointed to RadixUI library, the `onInteractOutside` seems to bug out in Firefox PR fixes following issue(s) Fixes #24820 #### Media Before: <img width="1728" alt="image" src="https://github.com/appsmithorg/appsmith/assets/8724051/723be5de-ac9b-4f47-b68c-3f3f2202732c"> After: <img width="1728" alt="image" src="https://github.com/appsmithorg/appsmith/assets/8724051/10c843f1-e83b-43cc-a4b3-ffca5ad14f26"> #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing #### How Has This Been Tested? - [x] Manual - [ ] Jest - [ ] Cypress #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
parent
a41ccec01e
commit
5253ed79e0
|
|
@ -99,7 +99,7 @@ export default function BranchMoreMenu({ branchName, open, setOpen }: Props) {
|
|||
<MenuContent
|
||||
align="end"
|
||||
onEscapeKeyDown={handleMenuClose}
|
||||
onInteractOutside={handleMenuClose}
|
||||
onPointerDownOutside={handleMenuClose}
|
||||
>
|
||||
{buttons}
|
||||
</MenuContent>
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user