From 519dd3a7a3449a7390e01ee21446aac2e12e7c47 Mon Sep 17 00:00:00 2001 From: Satish Gandham Date: Wed, 14 Dec 2022 18:39:53 +0530 Subject: [PATCH] ci: Make perf tests a blocking check (#18955) Make perf tests a blocking check Co-authored-by: Satish Gandham --- .../workflows/integration-tests-command.yml | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/workflows/integration-tests-command.yml b/.github/workflows/integration-tests-command.yml index d0713e8eeb..f1ca434bef 100644 --- a/.github/workflows/integration-tests-command.yml +++ b/.github/workflows/integration-tests-command.yml @@ -825,8 +825,18 @@ jobs: # Set status = success - run: echo "::set-output name=run_result::success" > ~/run_result + perf-test: + needs: [client-build, server-build, rts-build] + # Only run if the build step is successful + if: success() + name: perf-test + uses: ./.github/workflows/perf-test.yml + secrets: inherit + with: + pr: ${{ github.event.client_payload.pull_request.number }} + ui-test-result: - needs: [ui-test, fat-container-test] + needs: [ui-test, fat-container-test, perf-test] # Only run if the ui-test with matrices step is successful if: always() runs-on: ubuntu-latest @@ -975,7 +985,7 @@ jobs: run: echo "$PAYLOAD_CONTEXT" - name: Check ui-test set status - if: needs.ui-test.result != 'success' || needs.fat-container-test.result != 'success' + if: needs.ui-test.result != 'success' || needs.fat-container-test.result != 'success' || needs.perf-test.result != 'success' run: exit 1 package: @@ -1046,12 +1056,3 @@ jobs: return result; } - perf-test: - needs: [client-build, server-build, rts-build] - # Only run if the build step is successful - if: success() - name: perf-test - uses: ./.github/workflows/perf-test.yml - secrets: inherit - with: - pr: ${{ github.event.client_payload.pull_request.number }}