Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #4835 from appsmithorg/fix/custom-chart-config-better-doc

Browse Source 
fixing docs and expectation strings on custom chart
This commit is contained in:
Somangshu Goswami 2021-06-04 16:04:15 +05:30 committed by GitHub
commit 4cf050147b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/src/components/propertyControls/CustomFusionChartControl.tsx
View File

@ -3,7 +3,7 @@ import InputTextControl, { InputText } from "./InputTextControl";
class CustomFusionChartControl extends InputTextControl { class CustomFusionChartControl extends InputTextControl {
render() { render() {
const expected = "{\n type: string,\n dataSource: Object\n}"; const expected = '{\n "type": string,\n "dataSource": Object\n}';
const { dataTreePath, label, placeholderText, propertyValue } = this.props; const { dataTreePath, label, placeholderText, propertyValue } = this.props;
return ( return (
<InputText <InputText

4
app/client/src/widgets/ChartWidget/propertyConfig.ts
View File

@ -68,8 +68,8 @@ export default [
children: [ children: [
{ {
helpText: helpText:
"Manually configure a FusionChart, see https://www.fusioncharts.com", "Manually configure a FusionChart, see https://docs.appsmith.com/widget-reference/chart#custom-chart",
placeholderText: `Enter {type: "bar2d","dataSource": {}}`, placeholderText: `Enter {"type": "bar2d","dataSource": {}}`,
propertyName: "customFusionChartConfig", propertyName: "customFusionChartConfig",
label: "Custom Fusion Chart Configuration", label: "Custom Fusion Chart Configuration",
controlType: "CUSTOM_FUSION_CHARTS_DATA", controlType: "CUSTOM_FUSION_CHARTS_DATA",