From 4a7ff6424233b0c47f2e86a2af3a78f9d4301eeb Mon Sep 17 00:00:00 2001 From: Alex Date: Fri, 6 Sep 2024 10:11:48 +0300 Subject: [PATCH] feat: action redesign, UQI upgrade AWS plugin config to dual zone format (#36092) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Upgrade AWS lambda plugin config to new format using SECTION_V2, SINGLE_COLUMN_ZONE, and DOUBLE_COLUMN_ZONE. Fixes #35488 ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 7af86d65c8dabd006c5c2fabaeb3d0886aa3bdcd > Cypress dashboard. > Tags: `@tag.All` > Spec: >
Thu, 05 Sep 2024 09:39:20 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No ## Summary by CodeRabbit - **New Features** - Enhanced user interface for the AWS Lambda plugin with updated control types, improving layout and interaction. - Introduced new input options, including a dedicated section for "Post body." - **Bug Fixes** - Updated control types to reflect improved functionality and user experience in the editor. --- .../src/main/resources/editor/invoke.json | 11 +++++-- .../src/main/resources/editor/list.json | 2 +- .../src/main/resources/editor/root.json | 32 +++++++++++-------- 3 files changed, 28 insertions(+), 17 deletions(-) diff --git a/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/invoke.json b/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/invoke.json index a6234eedaf..fb9b4df449 100644 --- a/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/invoke.json +++ b/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/invoke.json @@ -1,12 +1,12 @@ { "identifier": "INVOKE_FUNCTION", - "controlType": "SECTION", + "controlType": "SECTION_V2", "conditionals": { "show": "{{actionConfiguration.formData.command.data === 'INVOKE_FUNCTION'}}" }, "children": [ { - "controlType": "SECTION", + "controlType": "DOUBLE_COLUMN_ZONE", "label": "Details of lambda function", "children": [ { @@ -63,7 +63,12 @@ "fetchOptionsConditionally": false, "setFirstOptionAsDefault": true, "alternateViewTypes": ["json"] - }, + } + ] + }, + { + "controlType": "SINGLE_COLUMN_ZONE", + "children": [ { "label": "Post body", "configProperty": "actionConfiguration.formData.body.data", diff --git a/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/list.json b/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/list.json index 72e004a0c0..897468ad1d 100644 --- a/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/list.json +++ b/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/list.json @@ -1,6 +1,6 @@ { "identifier": "LIST_FUNCTIONS", - "controlType": "SECTION", + "controlType": "SECTION_V2", "conditionals": { "show": "{{actionConfiguration.formData.command.data === 'LIST_FUNCTIONS'}}" }, diff --git a/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/root.json b/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/root.json index 5eda374173..00bc0a8e40 100644 --- a/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/root.json +++ b/app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/root.json @@ -1,23 +1,29 @@ { "editor": [ { - "controlType": "SECTION", + "controlType": "SECTION_V2", "identifier": "SELECTOR", + "children": [ { - "label": "Command", - "description": "Choose the method you would like to use", - "configProperty": "actionConfiguration.formData.command.data", - "controlType": "DROP_DOWN", - "initialValue": "LIST_FUNCTIONS", - "options": [ + "controlType": "DOUBLE_COLUMN_ZONE", + "children": [ { - "label": "List all functions", - "value": "LIST_FUNCTIONS" - }, - { - "label": "Invoke a function", - "value": "INVOKE_FUNCTION" + "label": "Command", + "description": "Choose the method you would like to use", + "configProperty": "actionConfiguration.formData.command.data", + "controlType": "DROP_DOWN", + "initialValue": "LIST_FUNCTIONS", + "options": [ + { + "label": "List all functions", + "value": "LIST_FUNCTIONS" + }, + { + "label": "Invoke a function", + "value": "INVOKE_FUNCTION" + } + ] } ] }