Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Application and page can only be deleted if you have manage application/page permissions respectively.

Browse Source
This commit is contained in:
Trisha Anand 2020-06-18 15:35:30 +05:30
parent 69dd082cf6
commit 4337e88934
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ApplicationPageServiceImpl.java
View File

@ -263,7 +263,7 @@ public class ApplicationPageServiceImpl implements ApplicationPageService {
public Mono<Application> deleteApplication(String id) { public Mono<Application> deleteApplication(String id) {
log.debug("Archiving application with id: {}", id); log.debug("Archiving application with id: {}", id);
Mono<Application> applicationMono = applicationService.findById(id) Mono<Application> applicationMono = applicationService.findById(id, MANAGE_APPLICATIONS)
.switchIfEmpty(Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, "application", id))) .switchIfEmpty(Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, "application", id)))
.flatMap(application -> { .flatMap(application -> {
log.debug("Archiving pages for applicationId: {}", id); log.debug("Archiving pages for applicationId: {}", id);

2
app/server/appsmith-server/src/main/java/com/appsmith/server/services/PageServiceImpl.java
View File

@ -104,7 +104,7 @@ public class PageServiceImpl extends BaseService<PageRepository, Page, String> i
*/ */
@Override @Override
public Mono<Page> delete(String id) { public Mono<Page> delete(String id) {
Mono<Page> pageMono = repository.findById(id) Mono<Page> pageMono = repository.findById(id, AclPermission.MANAGE_PAGES)
.switchIfEmpty(Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, FieldName.PAGE_ID, id))) .switchIfEmpty(Mono.error(new AppsmithException(AppsmithError.NO_RESOURCE_FOUND, FieldName.PAGE_ID, id)))
.flatMap(page -> { .flatMap(page -> {
log.debug("Going to archive pageId: {} for applicationId: {}", page.getId(), page.getApplicationId()); log.debug("Going to archive pageId: {} for applicationId: {}", page.getId(), page.getApplicationId());