Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge branch 'fix/runQueryTwice' into 'release'

Browse Source 
Use isExecutionSuccess flag to handle query execution errors

See merge request theappsmith/internal-tools-client!684
This commit is contained in:
Arpit Mohan 2020-06-10 12:25:54 +00:00
commit 4322555d16
1 changed files with 20 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
app/client/src/sagas/QueryPaneSagas.ts
View File

@ -251,25 +251,29 @@ export function* executeQuerySaga(
}, },
timeout, timeout,
); );
const isValidResponse = yield validateResponse(response);
const isExecutionSuccess = response.data.isExecutionSuccess;
if (response.responseMeta && response.responseMeta.error) { if (!isExecutionSuccess) {
throw response.responseMeta.error; throw Error(response.data.body.toString());
} }
yield put({ if (isValidResponse) {
type: ReduxActionTypes.RUN_QUERY_SUCCESS, yield put({
payload: { type: ReduxActionTypes.RUN_QUERY_SUCCESS,
data: response.data, payload: {
actionId: actionPayload.payload.actionId, data: response.data,
}, actionId: actionPayload.payload.actionId,
}); },
AppToaster.show({ });
message: "Query ran successfully", AppToaster.show({
type: ToastType.SUCCESS, message: "Query ran successfully",
}); type: ToastType.SUCCESS,
AnalyticsUtil.logEvent("RUN_QUERY", { });
queryName: actionPayload.payload.action.name, AnalyticsUtil.logEvent("RUN_QUERY", {
}); queryName: actionPayload.payload.action.name,
});
}
} catch (error) { } catch (error) {
yield put({ yield put({
type: ReduxActionErrorTypes.RUN_QUERY_ERROR, type: ReduxActionErrorTypes.RUN_QUERY_ERROR,