From 40bd7733b230f23efcc50cbc44d8b69bdefc70b1 Mon Sep 17 00:00:00 2001 From: Nilansh Bansal Date: Fri, 14 Apr 2023 11:32:05 +0530 Subject: [PATCH] fix: App nav upload logo thumbnail false (#22342) ## Description > This PR fixes the logo upload which was by default getting set to a thumbnail type size. Fixes #22293 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. > Please also list any relevant details for your test configuration. > Delete anything that is not important - Manual - Jest - Cypress ### Test Plan > Add Testsmith test cases links that relate to this PR ### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --- .../appsmith/server/services/ce/ApplicationServiceCEImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationServiceCEImpl.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationServiceCEImpl.java index 2f354f4882..887f4c408b 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationServiceCEImpl.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationServiceCEImpl.java @@ -786,7 +786,7 @@ public class ApplicationServiceCEImpl extends BaseService prevAssetIdMono = Mono.just(rootAppLogoAssetId); - final Mono uploaderMono = assetService.upload(List.of(filePart), MAX_LOGO_SIZE_KB, true); + final Mono uploaderMono = assetService.upload(List.of(filePart), MAX_LOGO_SIZE_KB, false); return Mono.zip(prevAssetIdMono, uploaderMono) .flatMap(tuple -> {