From 8118b2d8c0cbff097116a46774c546c523e3dd75 Mon Sep 17 00:00:00 2001 From: Nikhil Nandagopal Date: Thu, 6 Aug 2020 14:31:28 +0530 Subject: [PATCH] Fix/copy changes (#230) * Added information to setup domain * Fixed incorrect var reference * Updated documentation message * Updated env template * updated template * removed debug echo * Updated Script * Updated Text * Removed option to connect to external mongo for fresh installs Exit script of docker desktop is not installed * Updated docker installation explanation * added a question to skip custom domain if user is installing locally * Inverted script question and * Removed question to determine local installation * Updated Popup CTA to Modal Updated query templates to contain bindings Added a message to display on API / Query errors * updated styles for evaluated value updated styles for auto complete * added spaces to questions * grouped data tree functions together in autocomplete * Updated autocomplete styles * Updated property pane styles to become more dense * Fixed lightning menu styling * fixed tests * Fixed Cypress test * added property to show / hide tabs Co-authored-by: Nikhil Nandagopal --- .../designSystems/appsmith/TabsComponent.tsx | 37 +++++++++++-------- .../mockResponses/WidgetConfigResponse.tsx | 1 + app/client/src/widgets/TabsWidget.tsx | 1 + 3 files changed, 23 insertions(+), 16 deletions(-) diff --git a/app/client/src/components/designSystems/appsmith/TabsComponent.tsx b/app/client/src/components/designSystems/appsmith/TabsComponent.tsx index 5ba211dec0..72079c8916 100644 --- a/app/client/src/components/designSystems/appsmith/TabsComponent.tsx +++ b/app/client/src/components/designSystems/appsmith/TabsComponent.tsx @@ -9,6 +9,7 @@ interface TabsComponentProps extends ComponentProps { children?: ReactNode; shouldScrollContents?: boolean; selectedTabId: string; + shouldShowTabs: boolean; onTabChange: (tabId: string) => void; tabs: Array<{ id: string; @@ -112,22 +113,26 @@ const TabsComponent = (props: TabsComponentProps) => { }, [props.shouldScrollContents]); return ( - - {props.tabs && - props.tabs.map((tab, index) => ( - ) => { - props.onTabChange(tab.id); - event.stopPropagation(); - }} - selected={props.selectedTabId === tab.id} - key={index} - > - {tab.label} - - ))} - - + {props.shouldShowTabs ? ( + + {props.tabs && + props.tabs.map((tab, index) => ( + ) => { + props.onTabChange(tab.id); + event.stopPropagation(); + }} + selected={props.selectedTabId === tab.id} + key={index} + > + {tab.label} + + ))} + + + ) : ( + undefined + )} id: string; label: string; }>; + shouldShowTabs: boolean; children: T[]; snapColumns?: number; snapRows?: number;