From 3fdce8462cdc8d4b1231669de8a8744d90623ea7 Mon Sep 17 00:00:00 2001 From: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Date: Wed, 27 Jul 2022 19:29:43 +0530 Subject: [PATCH] fix: onboarding visual distraction from the entity explorer being hidden (#15446) --- .../ClientSideTests/Onboarding/GuidedTour_spec.js | 2 ++ app/client/src/sagas/OnboardingSagas.ts | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js index 9f9154e9ed..0c01212d6a 100644 --- a/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js +++ b/app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js @@ -1,6 +1,7 @@ const guidedTourLocators = require("../../../../locators/GuidedTour.json"); const onboardingLocators = require("../../../../locators/FirstTimeUserOnboarding.json"); const commonlocators = require("../../../../locators/commonlocators.json"); +const explorerLocators = require("../../../../locators/explorerlocators.json"); describe("Guided Tour", function() { it("Guided tour should work when started from the editor", function() { @@ -17,6 +18,7 @@ describe("Guided Tour", function() { cy.get(commonlocators.homeIcon).click({ force: true }); cy.get(guidedTourLocators.welcomeTour).click(); cy.get(guidedTourLocators.startBuilding).click(); + cy.get(explorerLocators.entityExplorer).should("not.be.visible"); // Step 1: Run query cy.runQuery(); cy.get(guidedTourLocators.successButton).click(); diff --git a/app/client/src/sagas/OnboardingSagas.ts b/app/client/src/sagas/OnboardingSagas.ts index 1b785df2e4..ae25bb0d4b 100644 --- a/app/client/src/sagas/OnboardingSagas.ts +++ b/app/client/src/sagas/OnboardingSagas.ts @@ -60,7 +60,10 @@ import { setPreviewModeAction } from "actions/editorActions"; import { FlattenedWidgetProps } from "widgets/constants"; import { ActionData } from "reducers/entityReducers/actionsReducer"; import { batchUpdateMultipleWidgetProperties } from "actions/controlActions"; -import { setExplorerPinnedAction } from "actions/explorerActions"; +import { + setExplorerActiveAction, + setExplorerPinnedAction, +} from "actions/explorerActions"; import { selectWidgetInitAction } from "actions/widgetSelectionActions"; import { hideIndicator } from "pages/Editor/GuidedTour/utils"; import { updateWidgetName } from "actions/propertyPaneActions"; @@ -175,6 +178,7 @@ function* setUpTourAppSaga() { ); // Hide the explorer initialy yield put(setExplorerPinnedAction(false)); + yield put(setExplorerActiveAction(false)); yield put(toggleLoader(false)); if (!query) return; history.push(