Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: onboarding visual distraction from the entity explorer being hidden (#15446)

Browse Source
This commit is contained in:
akash-codemonk 2022-07-27 19:29:43 +05:30 committed by GitHub
parent 712e15a1fc
commit 3fdce8462c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
View File

@ -1,6 +1,7 @@
const guidedTourLocators = require("../../../../locators/GuidedTour.json");
const onboardingLocators = require("../../../../locators/FirstTimeUserOnboarding.json");
const commonlocators = require("../../../../locators/commonlocators.json");
const explorerLocators = require("../../../../locators/explorerlocators.json");
describe("Guided Tour", function() {
it("Guided tour should work when started from the editor", function() {
@ -17,6 +18,7 @@ describe("Guided Tour", function() {
cy.get(commonlocators.homeIcon).click({ force: true });
cy.get(guidedTourLocators.welcomeTour).click();
cy.get(guidedTourLocators.startBuilding).click();
cy.get(explorerLocators.entityExplorer).should("not.be.visible");
// Step 1: Run query
cy.runQuery();
cy.get(guidedTourLocators.successButton).click();

6
app/client/src/sagas/OnboardingSagas.ts
View File

@ -60,7 +60,10 @@ import { setPreviewModeAction } from "actions/editorActions";
import { FlattenedWidgetProps } from "widgets/constants";
import { ActionData } from "reducers/entityReducers/actionsReducer";
import { batchUpdateMultipleWidgetProperties } from "actions/controlActions";
import { setExplorerPinnedAction } from "actions/explorerActions";
import {
setExplorerActiveAction,
setExplorerPinnedAction,
} from "actions/explorerActions";
import { selectWidgetInitAction } from "actions/widgetSelectionActions";
import { hideIndicator } from "pages/Editor/GuidedTour/utils";
import { updateWidgetName } from "actions/propertyPaneActions";
@ -175,6 +178,7 @@ function* setUpTourAppSaga() {
);
// Hide the explorer initialy
yield put(setExplorerPinnedAction(false));
yield put(setExplorerActiveAction(false));
yield put(toggleLoader(false));
if (!query) return;
history.push(