diff --git a/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js b/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js index 114649375e..597673d113 100644 --- a/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js +++ b/app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_spec.js @@ -95,12 +95,12 @@ describe("Admin settings page", { tags: ["@tag.Settings"] }, function () { cy.get("@pricingPage").should("be.called"); cy.wait(2000); cy.go(-1); - cy.stubPricingPage(); + cy.stubCustomerPortalPage(); cy.get(adminsSettings.branding).click(); cy.url().should("contain", adminSettingsHelper.routes.BRANDING); cy.get(adminsSettings.brandingSubmitButton).should("be.disabled"); cy.xpath(adminsSettings.upgrade).click(); - cy.get("@pricingPage").should("be.called"); + cy.get("@customerPortalPage").should("be.called"); cy.wait(2000); cy.go(-1); } @@ -119,11 +119,14 @@ describe("Admin settings page", { tags: ["@tag.Settings"] }, function () { }); cy.get(adminsSettings.accessControl).click(); cy.url().should("contain", adminSettingsHelper.routes.ACCESS_CONTROL); - cy.stubPricingPage(); + cy.stubCustomerPortalPage(); cy.xpath(adminsSettings.upgrade).click(); - cy.get("@pricingPage").should("be.called"); + cy.get("@customerPortalPage").should("be.called"); cy.wait(2000); - cy.go(-1); + agHelper.VisitNAssert( + adminSettingsHelper.routes.GENERAL, + "getEnvVariables", + ); cy.get(adminsSettings.auditLogs).within(() => { cy.get(adminsSettings.businessTag) .should("exist") @@ -131,11 +134,14 @@ describe("Admin settings page", { tags: ["@tag.Settings"] }, function () { }); cy.get(adminsSettings.auditLogs).click(); cy.url().should("contain", adminSettingsHelper.routes.AUDIT_LOGS); - cy.stubPricingPage(); + cy.stubCustomerPortalPage(); cy.xpath(adminsSettings.upgrade).click(); - cy.get("@pricingPage").should("be.called"); + cy.get("@customerPortalPage").should("be.called"); cy.wait(2000); - cy.go(-1); + agHelper.VisitNAssert( + adminSettingsHelper.routes.GENERAL, + "getEnvVariables", + ); cy.get(adminsSettings.provisioning).within(() => { cy.get(adminsSettings.enterpriseTag) .should("exist") diff --git a/app/client/cypress/support/commands.js b/app/client/cypress/support/commands.js index ce0769a313..a888f44863 100644 --- a/app/client/cypress/support/commands.js +++ b/app/client/cypress/support/commands.js @@ -2076,6 +2076,14 @@ Cypress.Commands.add("stubPricingPage", () => { }); }); +Cypress.Commands.add("stubCustomerPortalPage", () => { + cy.window().then((win) => { + cy.stub(win, "open", (url) => { + win.location.href = "https://customer.appsmith.com?"; + }).as("customerPortalPage"); + }); +}); + /** * @param testID * @returns diff --git a/app/client/src/ce/pages/Upgrade/ProvisioningUpgradePage.tsx b/app/client/src/ce/pages/Upgrade/ProvisioningUpgradePage.tsx index f4d5eda917..42201f84dd 100644 --- a/app/client/src/ce/pages/Upgrade/ProvisioningUpgradePage.tsx +++ b/app/client/src/ce/pages/Upgrade/ProvisioningUpgradePage.tsx @@ -22,6 +22,7 @@ export function ProvisioningUpgradePage() { logEventData: { source: "Provisioning" }, featureName: RampFeature.Provisioning, sectionName: RampSection.AdminSettings, + isEnterprise: true, }); const header: Header = { diff --git a/app/client/src/components/editorComponents/ActionNameEditor.tsx b/app/client/src/components/editorComponents/ActionNameEditor.tsx index 6301f9980f..6339e1c797 100644 --- a/app/client/src/components/editorComponents/ActionNameEditor.tsx +++ b/app/client/src/components/editorComponents/ActionNameEditor.tsx @@ -9,7 +9,7 @@ import { removeSpecialChars } from "utils/helpers"; import type { AppState } from "@appsmith/reducers"; import { saveActionName } from "actions/pluginActionActions"; -import { Flex, Spinner } from "design-system"; +import { Flex } from "design-system"; import { getAction, getPlugin } from "@appsmith/selectors/entitiesSelector"; import NameEditorComponent, { IconBox, @@ -116,7 +116,6 @@ function ActionNameEditor(props: ActionNameEditorProps) { updating={saveStatus.isSaving} valueTransform={removeSpecialChars} /> - {saveStatus.isSaving && } )} diff --git a/app/client/src/components/editorComponents/EditableText.tsx b/app/client/src/components/editorComponents/EditableText.tsx index 7dc9b0ca43..9ca152518c 100644 --- a/app/client/src/components/editorComponents/EditableText.tsx +++ b/app/client/src/components/editorComponents/EditableText.tsx @@ -6,7 +6,7 @@ import { } from "@blueprintjs/core"; import styled from "styled-components"; import _ from "lodash"; -import { Button, toast, Tooltip } from "design-system"; +import { Button, Spinner, toast, Tooltip } from "design-system"; export enum EditInteractionKind { SINGLE, @@ -221,13 +221,8 @@ export function EditableText(props: EditableTextProps) { [valueTransform, isInvalid], ); - const showEditIcon = !( - disabled || - minimal || - hideEditIcon || - updating || - isEditing - ); + const showEditIcon = !(disabled || minimal || hideEditIcon || isEditing); + return ( - {showEditIcon && ( -