From 3db43a531bb66191ca139a1d834d828347725243 Mon Sep 17 00:00:00 2001 From: Arpit Mohan Date: Fri, 16 Oct 2020 14:01:56 +0530 Subject: [PATCH] Adding comments for server workflow for docker push command Ensures that there are no errors in the future --- .github/workflows/server.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/server.yml b/.github/workflows/server.yml index b357d3856a..33e42df2d3 100644 --- a/.github/workflows/server.yml +++ b/.github/workflows/server.yml @@ -73,6 +73,8 @@ jobs: run: | docker build -t appsmith/appsmith-server:${{steps.vars.outputs.tag}} . echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin + # This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful + # with this command docker push appsmith/appsmith-server # Build master Docker image and push to Docker Hub @@ -82,6 +84,8 @@ jobs: docker build -t appsmith/appsmith-server:${GITHUB_SHA} . docker build -t appsmith/appsmith-server:nightly . echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin + # This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful + # with this command docker push appsmith/appsmith-server # These are dummy jobs in the CI build to satisfy required status checks for merging PRs. This is a hack because Github doesn't support conditional