Adding comments for server workflow for docker push command

Ensures that there are no errors in the future
This commit is contained in:
Arpit Mohan 2020-10-16 14:01:56 +05:30
parent 277b97cf3f
commit 3db43a531b

View File

@ -73,6 +73,8 @@ jobs:
run: |
docker build -t appsmith/appsmith-server:${{steps.vars.outputs.tag}} .
echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
# This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful
# with this command
docker push appsmith/appsmith-server
# Build master Docker image and push to Docker Hub
@ -82,6 +84,8 @@ jobs:
docker build -t appsmith/appsmith-server:${GITHUB_SHA} .
docker build -t appsmith/appsmith-server:nightly .
echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
# This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful
# with this command
docker push appsmith/appsmith-server
# These are dummy jobs in the CI build to satisfy required status checks for merging PRs. This is a hack because Github doesn't support conditional