Adding comments for server workflow for docker push command
Ensures that there are no errors in the future
This commit is contained in:
parent
277b97cf3f
commit
3db43a531b
4
.github/workflows/server.yml
vendored
4
.github/workflows/server.yml
vendored
|
|
@ -73,6 +73,8 @@ jobs:
|
|||
run: |
|
||||
docker build -t appsmith/appsmith-server:${{steps.vars.outputs.tag}} .
|
||||
echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
|
||||
# This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful
|
||||
# with this command
|
||||
docker push appsmith/appsmith-server
|
||||
|
||||
# Build master Docker image and push to Docker Hub
|
||||
|
|
@ -82,6 +84,8 @@ jobs:
|
|||
docker build -t appsmith/appsmith-server:${GITHUB_SHA} .
|
||||
docker build -t appsmith/appsmith-server:nightly .
|
||||
echo ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin
|
||||
# This command pushes all the tags on the machine to Docker hub. This has been written for ease of reading. Be very careful
|
||||
# with this command
|
||||
docker push appsmith/appsmith-server
|
||||
|
||||
# These are dummy jobs in the CI build to satisfy required status checks for merging PRs. This is a hack because Github doesn't support conditional
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user