Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix NPE in action execution analytics (#3541)

Browse Source 
The NPE noticed is with the return value of `.getStatusCode`.
But this PR adds NPE guards to a few other potential cases.
This commit is contained in:
Shrikant Sharat Kandula 2021-03-14 07:58:27 +05:30 committed by GitHub
parent 3a47e085e3
commit 3d6bd51556
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/server/appsmith-server/src/main/java/com/appsmith/server/services/NewActionServiceImpl.java
View File

@ -42,6 +42,7 @@ import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang.ArrayUtils;
import org.apache.commons.lang3.ObjectUtils;
import org.springframework.data.domain.Sort;
import org.springframework.data.mongodb.core.ReactiveMongoTemplate;
import org.springframework.data.mongodb.core.convert.MongoConverter;
@ -753,10 +754,10 @@ public class NewActionServiceImpl extends BaseService<NewActionRepository, NewAc
));
data.putAll(Map.of(
"pageId", actionDTO.getPageId(),
"pageId", ObjectUtils.defaultIfNull(actionDTO.getPageId(), ""),
"pageName", pageName,
"isSuccessfulExecution", actionExecutionResult.getIsExecutionSuccess(),
"statusCode", actionExecutionResult.getStatusCode(),
"isSuccessfulExecution", ObjectUtils.defaultIfNull(actionExecutionResult.getIsExecutionSuccess(), false),
"statusCode", ObjectUtils.defaultIfNull(actionExecutionResult.getStatusCode(), ""),
"timeElapsed", timeElapsed
));