chore: fixed type issue for moduleInstances (#37208)
## Description Fixed type issue for moduleInstances in the dataTreeFactory. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11668431804> > Commit: 1e988df3ad09cac3b57caf73e0f18b450307dab6 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11668431804&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 04 Nov 2024 17:20:56 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced type safety for the `moduleInstanceEntities` parameter in the `DataTreeFactory` class, improving clarity and maintainability. - **Bug Fixes** - Removed the ESLint directive that suppressed warnings about the use of `any`, promoting stricter type enforcement. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
parent
7ccb2ea697
commit
3bd61a2bbf
|
|
@ -24,6 +24,8 @@ import type {
|
|||
DependencyMap,
|
||||
FormEditorConfigs,
|
||||
} from "utils/DynamicBindingUtils";
|
||||
import type { DataTreeSeed } from "ee/entities/DataTree/types";
|
||||
|
||||
export class DataTreeFactory {
|
||||
public static metaWidgets(
|
||||
metaWidgets: MetaWidgetsReduxState,
|
||||
|
|
@ -52,11 +54,10 @@ export class DataTreeFactory {
|
|||
};
|
||||
}
|
||||
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
public static widgets(
|
||||
moduleInputs: Module["inputsForm"],
|
||||
moduleInstances: Record<string, ModuleInstance> | null,
|
||||
moduleInstanceEntities: null,
|
||||
moduleInstanceEntities: DataTreeSeed["moduleInstanceEntities"],
|
||||
widgets: CanvasWidgetsReduxState,
|
||||
widgetsMeta: MetaState,
|
||||
loadingEntities: LoadingEntitiesState,
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user