Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Fix: Deleting a tab from a tab widget from the explorer would not reflect in the canvas(#3218)

Browse Source
This commit is contained in:
akash-codemonk 2021-03-04 15:24:01 +05:30 committed by GitHub
parent 1e4878f983
commit 39e4990a7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/client/src/sagas/WidgetOperationSagas.tsx
View File

@ -40,6 +40,7 @@ import {
SetWidgetDynamicPropertyPayload, SetWidgetDynamicPropertyPayload,
updateWidgetProperty, updateWidgetProperty,
UpdateWidgetPropertyPayload, UpdateWidgetPropertyPayload,
updateWidgetPropertyRequest,
UpdateWidgetPropertyRequestPayload, UpdateWidgetPropertyRequestPayload,
} from "actions/controlActions"; } from "actions/controlActions";
import { import {
@ -433,6 +434,23 @@ export function* deleteSaga(deleteAction: ReduxAction<WidgetDelete>) {
// SPECIAL HANDLING FOR TABS IN A TABS WIDGET // SPECIAL HANDLING FOR TABS IN A TABS WIDGET
if (parent.type === WidgetTypes.TABS_WIDGET && widget.tabName) { if (parent.type === WidgetTypes.TABS_WIDGET && widget.tabName) {
widgetName = widget.tabName; widgetName = widget.tabName;
// Deleting a tab from the explorer doesn't remove the same
// from the "tabs" property of the widget.
// So updating the widget property here when the children length doesn't match
// `tabs` length
if (parent.children?.length !== parent.tabs.length) {
const filteredTabs = parent.tabs.filter(
(tab: any) => tab.widgetId !== widgetId,
);
yield put(
updateWidgetPropertyRequest(
parentId,
"tabs",
filteredTabs,
RenderModes.CANVAS,
),
);
}
} }
if (saveStatus && !disallowUndo) { if (saveStatus && !disallowUndo) {
Toaster.show({ Toaster.show({