From 39c5863ba8627a0fa19d99664d72b8ba4ee596f2 Mon Sep 17 00:00:00 2001 From: Ankita Kinger Date: Mon, 2 Jan 2023 17:48:26 +0530 Subject: [PATCH] fix: Updating placeholder of input field on invite modal used on edit & deployed app (#19245) ## Description > Updating placeholder of input field on invite modal used on edit & deployed app Fixes [#19309](https://github.com/appsmithorg/appsmith/issues/19309) ## Type of change - Updating placeholder ## How Has This Been Tested? > Works as expected now. - Manual ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [ ] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [ ] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test --- app/client/package.json | 2 +- .../src/ce/pages/workspace/WorkspaceInviteUsersForm.tsx | 1 + app/client/src/pages/workspace/AppInviteUsersForm.tsx | 2 ++ app/client/yarn.lock | 8 ++++---- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/app/client/package.json b/app/client/package.json index 112df52f0a..071aefc36b 100644 --- a/app/client/package.json +++ b/app/client/package.json @@ -46,7 +46,7 @@ "cypress-log-to-output": "^1.1.2", "dayjs": "^1.10.6", "deep-diff": "^1.0.2", - "design-system": "npm:@appsmithorg/design-system@1.0.42", + "design-system": "npm:@appsmithorg/design-system@1.0.43", "downloadjs": "^1.4.7", "draft-js": "^0.11.7", "exceljs-lightweight": "^1.14.0", diff --git a/app/client/src/ce/pages/workspace/WorkspaceInviteUsersForm.tsx b/app/client/src/ce/pages/workspace/WorkspaceInviteUsersForm.tsx index 3862b1b47e..22769824f8 100644 --- a/app/client/src/ce/pages/workspace/WorkspaceInviteUsersForm.tsx +++ b/app/client/src/ce/pages/workspace/WorkspaceInviteUsersForm.tsx @@ -636,6 +636,7 @@ export default connect( applicationId?: string; workspaceId?: string; isApplicationInvite?: boolean; + placeholder?: string; } >({ validate, diff --git a/app/client/src/pages/workspace/AppInviteUsersForm.tsx b/app/client/src/pages/workspace/AppInviteUsersForm.tsx index 23fda61d1e..b7b4fa93b4 100644 --- a/app/client/src/pages/workspace/AppInviteUsersForm.tsx +++ b/app/client/src/pages/workspace/AppInviteUsersForm.tsx @@ -21,6 +21,7 @@ import useWorkspace from "utils/hooks/useWorkspace"; import TooltipWrapper from "pages/Applications/EmbedSnippet/TooltipWrapper"; import { createMessage, + INVITE_USERS_PLACEHOLDER, IN_APP_EMBED_SETTING, MAKE_APPLICATION_PUBLIC, MAKE_APPLICATION_PUBLIC_TOOLTIP, @@ -85,6 +86,7 @@ function AppInviteUsersForm(props: any) { {canInviteToWorkspace && ( )} diff --git a/app/client/yarn.lock b/app/client/yarn.lock index 5a683ee807..649fbd1d4f 100644 --- a/app/client/yarn.lock +++ b/app/client/yarn.lock @@ -6202,10 +6202,10 @@ depd@~1.1.2: version "1.1.2" resolved "https://registry.npmjs.org/depd/-/depd-1.1.2.tgz" -"design-system@npm:@appsmithorg/design-system@1.0.42": - version "1.0.42" - resolved "https://registry.yarnpkg.com/@appsmithorg/design-system/-/design-system-1.0.42.tgz#b3db1d09528a2ccc7c509de39cb78e723015828e" - integrity sha512-BHe9uEHT+sVNwPi4bJ6DP+Wq0QNIi69eEJ6q8dsKmzLXlD4XUJd2hGd6ekKn25f72QvChVmHd/fkvTydnGoiNA== +"design-system@npm:@appsmithorg/design-system@1.0.43": + version "1.0.43" + resolved "https://registry.yarnpkg.com/@appsmithorg/design-system/-/design-system-1.0.43.tgz#f52380e44259ec11f9159be10977d2d6b94a9449" + integrity sha512-hn+8EYtDEUwwVFSS76yBWdMlmUOtvXVb+7eimNOVIS5ml9rLiT+bQC7sq3hd9h5cDw0MME2BHMrpWdBx3SlfwA== dependencies: emoji-mart "3.0.1"