fix: Menu button widget height not changing on resizing (#25777)
## Description Allows the menu button's height to change as the widget is resized. #### PR fixes following issue(s) Fixes #25738 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [x] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [x] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
parent
cf6d9a6e93
commit
3803b9e562
|
|
@ -50,7 +50,7 @@ const PopoverStyles = createGlobalStyle<{
|
|||
margin-bottom: 8px !important;
|
||||
border-radius: ${({ borderRadius }) =>
|
||||
borderRadius >= THEMEING_TEXT_SIZES.lg ? `0.375rem` : borderRadius};
|
||||
overflow-y: scroll;
|
||||
overflow-y: auto;
|
||||
max-height: 384px;
|
||||
}
|
||||
|
||||
|
|
@ -59,7 +59,7 @@ const PopoverStyles = createGlobalStyle<{
|
|||
border-radius: 0;
|
||||
}
|
||||
|
||||
& > .${Classes.POPOVER2_TARGET} {
|
||||
.menu-button-popover-target {
|
||||
height: 100%;
|
||||
}
|
||||
|
||||
|
|
@ -389,6 +389,7 @@ function MenuButtonComponent(props: MenuButtonComponentProps) {
|
|||
parentWidth={width - WidgetContainerDiff}
|
||||
/>
|
||||
<Popover2
|
||||
className="menu-button-popover-target"
|
||||
content={
|
||||
<PopoverContent
|
||||
backgroundColor={menuColor}
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user