chore: Minor changes for fixing some strings on the home page & action settings page (#7469)

This commit is contained in:
Arpit Mohan 2021-09-15 17:50:25 +05:30 committed by GitHub
parent 851abd5a06
commit 37e7a61792
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 31 additions and 11 deletions

View File

@ -174,6 +174,16 @@ export const EDIT_APP = () => `Edit App`;
export const FORK_APP = () => `Fork App`;
export const SIGN_IN = () => `Sign In`;
// Homepage
export const CREATE_NEW_APPLICATION = () => `Create New`;
export const SEARCH_APPS = () => `Search for apps...`;
export const GETTING_STARTED = () => `GETTING STARTED`;
export const ORGANIZATIONS_HEADING = () => `ORGANIZATIONS`;
export const WELCOME_TOUR = () => `Welcome Tour`;
export const NO_APPS_FOUND = () =>
`Whale! Whale! This name doesn't ring a bell!`;
// Lightning menu
export const LIGHTNING_MENU_DATA_API = () => `Use data from an API`;
export const LIGHTNING_MENU_DATA_QUERY = () => `Use data from a Query`;
export const LIGHTNING_MENU_DATA_TOOLTIP = () => `Quick start data binding`;

View File

@ -85,6 +85,16 @@ import {
extractAppIdAndPageIdFromUrl,
SIGNUP_SUCCESS_URL,
} from "constants/routes";
import {
createMessage,
CREATE_NEW_APPLICATION,
DOCUMENTATION,
GETTING_STARTED,
ORGANIZATIONS_HEADING,
SEARCH_APPS,
WELCOME_TOUR,
NO_APPS_FOUND,
} from "constants/messages";
import { getIsSafeRedirectURL } from "utils/helpers";
import history from "utils/history";
@ -410,7 +420,7 @@ function LeftPane() {
return (
<LeftPaneWrapper>
<LeftPaneSection
heading="ORGANIZATIONS"
heading={createMessage(ORGANIZATIONS_HEADING)}
isFetchingApplications={isFetchingApplications}
>
<WorkpsacesNavigator data-cy="t--left-panel">
@ -444,7 +454,7 @@ function LeftPane() {
<div style={{ marginTop: 12 }}>
<Item
isFetchingApplications={isFetchingApplications}
label={"GETTING STARTED"}
label={createMessage(GETTING_STARTED)}
textType={TextType.H6}
/>
</div>
@ -456,7 +466,7 @@ function LeftPane() {
onSelect={() => {
window.open("https://docs.appsmith.com/", "_blank");
}}
text={"Documentation"}
text={createMessage(DOCUMENTATION)}
/>
<MenuItem
containerClassName={
@ -470,7 +480,7 @@ function LeftPane() {
initiateOnboarding();
}}
text={"Welcome Tour"}
text={createMessage(WELCOME_TOUR)}
/>
</WorkpsacesNavigator>
</LeftPaneSection>
@ -635,7 +645,7 @@ function ApplicationsSection(props: any) {
organizationsListComponent = (
<CenteredWrapper style={{ flexDirection: "column", marginTop: "-150px" }}>
<CreateNewLabel type={TextType.H4}>
Whale! Whale! this name doesn&apos;t ring a bell!
{createMessage(NO_APPS_FOUND)}
</CreateNewLabel>
<NoSearchResultImg alt="No result found" src={NoSearchImage} />
</CenteredWrapper>
@ -845,7 +855,7 @@ function ApplicationsSection(props: any) {
className="createnew"
type={TextType.H4}
>
Create New
{createMessage(CREATE_NEW_APPLICATION)}
</CreateNewLabel>
</>
)}
@ -960,7 +970,7 @@ class Applications extends Component<
<LeftPane />
<SubHeader
search={{
placeholder: "Search for apps...",
placeholder: createMessage(SEARCH_APPS),
queryFn: this.props.searchApplications,
defaultValue: this.props.searchKeyword,
}}

View File

@ -18,7 +18,7 @@
},
{
"label": "Use Prepared Statement",
"info": "Turning on Prepared Statement makes the query parametrized. This in turn makes it resilient against SQL injections",
"info": "Turning on Prepared Statement makes the query parameterized. This in turn makes it resilient against SQL injections",
"configProperty": "actionConfiguration.pluginSpecifiedTemplates[0].value",
"controlType": "SWITCH",
"initialValue": true

View File

@ -18,7 +18,7 @@
},
{
"label": "Use Prepared Statement",
"info": "Turning on Prepared Statement makes the query parametrized. This in turn makes it resilient against SQL injections",
"info": "Turning on Prepared Statement makes the query parameterized. This in turn makes it resilient against SQL injections",
"configProperty": "actionConfiguration.pluginSpecifiedTemplates[0].value",
"controlType": "SWITCH",
"initialValue": true

View File

@ -18,7 +18,7 @@
},
{
"label": "Use Prepared Statement",
"info": "Turning on Prepared Statement makes the query parametrized. This in turn makes it resilient against SQL injections",
"info": "Turning on Prepared Statement makes the query parameterized. This in turn makes it resilient against SQL injections",
"configProperty": "actionConfiguration.pluginSpecifiedTemplates[0].value",
"controlType": "SWITCH",
"initialValue": true

View File

@ -456,7 +456,7 @@ public class ApplicationPageServiceImpl implements ApplicationPageService {
Application sourceApplication = tuple.getT1();
String newName = tuple.getT2();
// Create a new clone application object without the pages using the parametrized Application constructor
// Create a new clone application object without the pages using the parameterized Application constructor
Application newApplication = new Application(sourceApplication);
newApplication.setName(newName);