Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: modal rename update references (#34855)

Browse Source
This commit is contained in:
Aman Agarwal 2024-07-12 22:22:02 +05:30 committed by GitHub
parent a4c394c995
commit 3767a62763
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 100 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
app/client/src/widgets/ModalWidget/widget/index.test.tsx Normal file
View File

@ -0,0 +1,90 @@
import ModalWidget from ".";
describe("Modal Widget default Props check", () => {
it("Check for icon and close button to have dynamicTriggerPathList as onClick key for modal references to update on rename", () => {
const defaultModalProps = ModalWidget.getDefaults();
const modalWidgetCanvasChild: any = {
type: "CANVAS_WIDGET",
widgetName: "Canvas1",
displayName: "Canvas",
children: [
{
type: "TEXT_WIDGET",
widgetName: "Text1",
displayName: "Text",
key: "41j4j00agt",
widgetId: "TEXT_WIDGET_ID",
parentId: "CANVAS_WIDGET_ID",
children: [],
},
{
type: "ICON_BUTTON_WIDGET",
widgetName: "IconButton1",
displayName: "Icon button",
widgetId: "ICON_BUTTON_WIDGET_ID",
parentId: "CANVAS_WIDGET_ID",
children: [],
},
{
type: "BUTTON_WIDGET",
text: "Close",
widgetName: "Button1",
key: "8eyy97tgkp",
widgetId: "BUTTON_WIDGET_ID",
parentId: "CANVAS_WIDGET_ID",
children: [],
},
{
type: "BUTTON_WIDGET",
text: "Confirm",
widgetName: "Button2",
key: "8eyy97tgkp",
widgetId: "BUTTON_WIDGET_ID_2",
parentId: "CANVAS_WIDGET_ID",
children: [],
},
],
widgetId: "CANVAS_WIDGET_ID",
parentId: "MODAL_WIDGET_ID",
};
const modalWidget: any = {
type: "MODAL_WIDGET",
widgetName: "Modal1",
children: [],
displayName: "Modal",
widgetId: "MODAL_WIDGET_ID",
parentId: "0",
dynamicHeight: "AUTO_HEIGHT",
};
const iconData =
defaultModalProps.blueprint.view[0].props.blueprint.operations[0].fn(
modalWidgetCanvasChild,
{},
modalWidget,
);
const closeButtonData =
defaultModalProps.blueprint.view[0].props.blueprint.operations[1].fn(
modalWidgetCanvasChild,
{},
modalWidget,
);
expect(iconData).not.toBeUndefined();
expect(iconData![1].propertyName).toContain("dynamicTriggerPathList");
expect((iconData![1].propertyValue[0] as { key: string }).key).toContain(
"onClick",
);
expect(closeButtonData).not.toBeUndefined();
expect(closeButtonData![1].propertyName).toContain(
"dynamicTriggerPathList",
);
expect(
(closeButtonData![1].propertyValue[0] as { key: string }).key,
).toContain("onClick");
});
});

10
app/client/src/widgets/ModalWidget/widget/index.tsx
View File

@ -180,6 +180,11 @@ export class ModalWidget extends BaseWidget<ModalWidgetProps, WidgetState> {
propertyName: "onClick",
propertyValue: `{{closeModal(${parent.widgetName}.name);}}`,
},
{
widgetId: iconChild.widgetId,
propertyName: "dynamicTriggerPathList",
propertyValue: [{ key: "onClick" }],
},
];
}
},
@ -206,6 +211,11 @@ export class ModalWidget extends BaseWidget<ModalWidgetProps, WidgetState> {
propertyName: "onClick",
propertyValue: `{{closeModal(${parent.widgetName}.name);}}`,
},
{
widgetId: cancelBtnChild.widgetId,
propertyName: "dynamicTriggerPathList",
propertyValue: [{ key: "onClick" }],
},
];
}
},