fix: App settings navigating out fixes (#28737)
## Description Sets the App Settings state to closed when navigating away from App Settings #### PR fixes following issue(s) Fixes #28736 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] JUnit - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
This commit is contained in:
parent
af845cda74
commit
32aa38eb5b
|
|
@ -27,7 +27,10 @@ import {
|
|||
import { Colors } from "constants/Colors";
|
||||
import EmbedSettings from "./EmbedSettings";
|
||||
import NavigationSettings from "./NavigationSettings";
|
||||
import { updateAppSettingsPaneSelectedTabAction } from "actions/appSettingsPaneActions";
|
||||
import {
|
||||
closeAppSettingsPaneAction,
|
||||
updateAppSettingsPaneSelectedTabAction,
|
||||
} from "actions/appSettingsPaneActions";
|
||||
import AnalyticsUtil from "utils/AnalyticsUtil";
|
||||
import { Divider } from "design-system";
|
||||
import { ImportAppSettings } from "./ImportAppSettings";
|
||||
|
|
@ -109,6 +112,10 @@ function AppSettings() {
|
|||
},
|
||||
}),
|
||||
);
|
||||
|
||||
return () => {
|
||||
dispatch(closeAppSettingsPaneAction());
|
||||
};
|
||||
}, [selectedTab]);
|
||||
|
||||
const SectionHeadersConfig: SectionHeaderProps[] = [
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user