Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: Reset echartsConfiguration when chartType is changed to CUSTOM_FUSION… (#25973)

Browse Source 
Fixes #25974
This commit is contained in:
Rajat Agrawal 2023-08-04 14:24:09 +05:30 committed by GitHub
parent 501f187c08
commit 317754fdbc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
app/client/src/widgets/ChartWidget/component/index.test.tsx
View File

@ -96,7 +96,54 @@ describe("Chart Widget", () => {
expect(fusionContainer).toBeInTheDocument();
});
it("2. adds a click event when user adds a click callback", async () => {
it("2. successfully switches sequence of basic chart/custom fusion chart/basic chart", async () => {
// First render with Area Chart
let props = JSON.parse(JSON.stringify(defaultProps));
props.chartType = "AREA_CHART";
const { container, getByText, rerender } = render(
<ChartComponent {...props} />,
);
let xAxisLabel = getByText("xaxisname");
expect(xAxisLabel).toBeInTheDocument();
let echartsContainer = container.querySelector("#widgetIDechart-container");
expect(echartsContainer).toBeInTheDocument();
let fusionContainer = container.querySelector(
"#widgetIDcustom-fusion-chart-container",
);
expect(fusionContainer).not.toBeInTheDocument();
// Second render with fusion charts
props = JSON.parse(JSON.stringify(defaultProps));
props.chartType = "CUSTOM_FUSION_CHART";
rerender(<ChartComponent {...props} />);
echartsContainer = container.querySelector("#widgetIDechart-container");
expect(echartsContainer).not.toBeInTheDocument();
fusionContainer = container.querySelector(
"#widgetIDcustom-fusion-chart-container",
);
expect(fusionContainer).toBeInTheDocument();
// Third render with Area charts again.
props = JSON.parse(JSON.stringify(defaultProps));
props.chartType = "AREA_CHART";
rerender(<ChartComponent {...props} />);
xAxisLabel = getByText("xaxisname");
expect(xAxisLabel).toBeInTheDocument();
echartsContainer = container.querySelector("#widgetIDechart-container");
expect(echartsContainer).toBeInTheDocument();
});
it("3. adds a click event when user adds a click callback", async () => {
const mockCallback = jest.fn();
const props = { ...defaultProps };
props.onDataPointClick = (point) => {

1
app/client/src/widgets/ChartWidget/component/index.tsx
View File

@ -251,6 +251,7 @@ class ChartComponent extends React.Component<
this.props.chartType == "CUSTOM_FUSION_CHART" &&
this.state.chartType != "CUSTOM_FUSION_CHART"
) {
this.echartConfiguration = {};
this.setState({
eChartsError: undefined,
chartType: "CUSTOM_FUSION_CHART",