Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: property pane if tabledata section doesn't exist, clear widget id (#27260)

Browse Source
This commit is contained in:
Aman Agarwal 2023-09-15 18:24:39 +05:30 committed by GitHub
parent 7e7df702c2
commit 316ef84a8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/client/src/components/featureWalkthrough/walkthroughRenderer.tsx
View File

@ -216,14 +216,18 @@ const WalkthroughRenderer = ({
0 ${targetBounds.bh},
${multipleHighlightsIds.reduce((acc, id) => {
const boundingRect = boundingRects[id];
acc = `${acc} ${boundingRect.tx} ${boundingRect.bh},
${boundingRect.tx} ${boundingRect.ty},
${boundingRect.tx + boundingRect.tw} ${boundingRect.ty},
${boundingRect.tx + boundingRect.tw} ${
boundingRect.ty + boundingRect.th
},
${boundingRect.tx} ${boundingRect.ty + boundingRect.th},
${boundingRect.tx} ${boundingRect.bh},`;
if (boundingRect) {
acc = `${acc} ${boundingRect.tx} ${boundingRect.bh},
${boundingRect.tx} ${boundingRect.ty},
${boundingRect.tx + boundingRect.tw} ${boundingRect.ty},
${boundingRect.tx + boundingRect.tw} ${
boundingRect.ty + boundingRect.th
},
${boundingRect.tx} ${
boundingRect.ty + boundingRect.th
},
${boundingRect.tx} ${boundingRect.bh},`;
}
return acc;
}, "")}
${targetBounds.bw} ${targetBounds.bh},

14
app/client/src/pages/Editor/PropertyPane/PropertySection.tsx
View File

@ -19,6 +19,7 @@ import { setPropertySectionState } from "actions/propertyPaneActions";
import { getIsOneClickBindingOptionsVisibility } from "selectors/oneClickBindingSelectors";
import localStorage from "utils/localStorage";
import { WIDGET_ID_SHOW_WALKTHROUGH } from "constants/WidgetConstants";
import { PROPERTY_PANE_ID } from "components/editorComponents/PropertyPaneSidebar";
const TagContainer = styled.div``;
@ -149,10 +150,17 @@ export const PropertySection = memo((props: PropertySectionProps) => {
);
if (widgetId) {
if (className === "data") {
setIsOpen(true);
const isWidgetIdTableDataExist = document.querySelector(
`#${PROPERTY_PANE_ID} [id='${btoa(widgetId + ".tableData")}']`,
);
if (isWidgetIdTableDataExist) {
if (className === "data") {
setIsOpen(true);
} else {
setIsOpen(false);
}
} else {
setIsOpen(false);
await localStorage.removeItem(WIDGET_ID_SHOW_WALKTHROUGH);
}
}
};