Protei/PromucFlow_constructor
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Minor code cleanup

Browse Source
This commit is contained in:
Trisha Anand 2020-04-24 15:15:39 +05:30
parent a8f32d8b2a
commit 2fa879fbd4
3 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/server/appsmith-server/src/main/java/com/appsmith/server/configurations/SecurityConfig.java
View File

@ -55,7 +55,7 @@ public class SecurityConfig {
private ReactiveClientRegistrationRepository reactiveClientRegistrationRepository;
@Autowired
ObjectMapper objectMapper;
private ObjectMapper objectMapper;
/**
* This routerFunction is required to map /public/** endpoints to the src/main/resources/public folder

2
app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/MarketplaceController.java
View File

@ -22,12 +22,10 @@ import java.util.List;
@RequestMapping(Url.MARKETPLACE_URL)
@Slf4j
public class MarketplaceController {
private final ObjectMapper objectMapper;
private final MarketplaceService marketplaceService;
public MarketplaceController(ObjectMapper objectMapper,
MarketplaceService marketplaceService) {
this.objectMapper = objectMapper;
this.marketplaceService = marketplaceService;
}

10
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ApplicationServiceImpl.java
View File

@ -8,7 +8,6 @@ import com.appsmith.server.domains.ApplicationPage;
import com.appsmith.server.domains.Layout;
import com.appsmith.server.exceptions.AppsmithError;
import com.appsmith.server.exceptions.AppsmithException;
import com.appsmith.server.repositories.ActionRepository;
import com.appsmith.server.repositories.ApplicationRepository;
import com.appsmith.server.repositories.PageRepository;
import lombok.extern.slf4j.Slf4j;
@ -32,12 +31,9 @@ import static com.appsmith.server.acl.AclPermission.READ_APPLICATIONS;
@Service
public class ApplicationServiceImpl extends BaseService<ApplicationRepository, Application, String> implements ApplicationService {
private final SessionUserService sessionUserService;
//Using PageRepository instead of PageService is because a cyclic dependency is introduced if PageService is used here.
//TODO : Solve for this across LayoutService, PageService and ApplicationService.
private final PageRepository pageRepository;
private final ActionRepository actionRepository;
@Autowired
public ApplicationServiceImpl(Scheduler scheduler,
@ -46,13 +42,9 @@ public class ApplicationServiceImpl extends BaseService<ApplicationRepository, A
ReactiveMongoTemplate reactiveMongoTemplate,
ApplicationRepository repository,
AnalyticsService analyticsService,
SessionUserService sessionUserService,
PageRepository pageRepository,
ActionRepository actionRepository) {
PageRepository pageRepository) {
super(scheduler, validator, mongoConverter, reactiveMongoTemplate, repository, analyticsService);
this.sessionUserService = sessionUserService;
this.pageRepository = pageRepository;
this.actionRepository = actionRepository;
}
@Override