From 577e9a7017abec18d4d318700a0f038b4125ed5f Mon Sep 17 00:00:00 2001 From: Shrikant Sharat Kandula Date: Wed, 23 Sep 2020 11:01:58 +0530 Subject: [PATCH] Refactor ignoreCache parameter to use Boolean type (#681) --- .../appsmith/server/controllers/DatasourceController.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/DatasourceController.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/DatasourceController.java index 0a2a2a3408..b11c0fe677 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/DatasourceController.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/controllers/DatasourceController.java @@ -8,6 +8,7 @@ import com.appsmith.server.dtos.ResponseDTO; import com.appsmith.server.services.DatasourceService; import com.appsmith.server.solutions.DatasourceStructureSolution; import lombok.extern.slf4j.Slf4j; +import org.apache.commons.lang3.BooleanUtils; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.http.HttpStatus; import org.springframework.web.bind.annotation.GetMapping; @@ -42,9 +43,9 @@ public class DatasourceController extends BaseController> getStructure(@PathVariable String datasourceId, - @RequestParam(required = false) String ignoreCache) { + @RequestParam(required = false, defaultValue = "false") Boolean ignoreCache) { log.debug("Going to get structure for datasource with id: '{}'.", datasourceId); - return datasourceStructureSolution.getStructure(datasourceId, "true".equalsIgnoreCase(ignoreCache)) + return datasourceStructureSolution.getStructure(datasourceId, BooleanUtils.isTrue(ignoreCache)) .map(structure -> new ResponseDTO<>(HttpStatus.OK.value(), structure, null)); }