From 2ec6610399df0966d9a772f37b43a35ff2f532a5 Mon Sep 17 00:00:00 2001 From: Ankita Kinger Date: Sat, 20 May 2023 06:19:33 +0530 Subject: [PATCH] chore: Updating locators for EE tests (#23563) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Updating locators for EE tests #### PR fixes following issue(s) Fixes # (issue number) > if no issue exists, please create an issue and ask the maintainers about this first > > #### Media > A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video > > #### Type of change > Please delete options that are not relevant. - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - Chore (housekeeping or task changes that don't impact user perception) - This change requires a documentation update > > > ## Testing > #### How Has This Been Tested? > Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. > Delete anything that is not relevant - [ ] Manual - [ ] Jest - [ ] Cypress > > #### Test Plan > Add Testsmith test cases links that relate to this PR > > #### Issues raised during DP testing > Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR) > > > ## Checklist: #### Dev activity - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [ ] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [ ] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [ ] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [ ] Cypress test cases have been added and approved by SDET/manual QA - [ ] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed --- app/client/cypress/locators/Widgets.json | 1 + app/client/cypress/support/WorkspaceCommands.js | 4 ++-- app/client/cypress/support/commands.js | 2 +- app/client/src/pages/Applications/ApplicationCard.tsx | 1 + 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/client/cypress/locators/Widgets.json b/app/client/cypress/locators/Widgets.json index 9f2873427b..d54ea5211f 100644 --- a/app/client/cypress/locators/Widgets.json +++ b/app/client/cypress/locators/Widgets.json @@ -193,6 +193,7 @@ "selectedTextSize": ".t--property-control-textsize .bp3-popover-target .sub-text", "colorPickerV2Popover": ".t--colorpicker-v2-popover", "colorPickerV2Color": ".t--colorpicker-v2-color", + "colorPickerV2PopoverContent": "[data-testid=\"color-picker\"]", "colorPickerV2TailwindColor": ".t--tailwind-colors .t--colorpicker-v2-color", "modalCloseButton": ".t--draggable-iconbuttonwidget .bp3-button", "filepickerwidgetv2": ".t--widget-filepickerwidgetv2", diff --git a/app/client/cypress/support/WorkspaceCommands.js b/app/client/cypress/support/WorkspaceCommands.js index 6dc65532a4..99804d54ba 100644 --- a/app/client/cypress/support/WorkspaceCommands.js +++ b/app/client/cypress/support/WorkspaceCommands.js @@ -160,7 +160,7 @@ Cypress.Commands.add("deleteUserFromWorkspace", (workspaceName) => { cy.get(homePage.workspaceList.concat(workspaceName).concat(")")) .closest(homePage.workspaceCompleteSection) - .find(homePage.workspaceNamePopover) + .scrollIntoView() .find(homePage.optionsIcon) .click({ force: true }); cy.xpath(homePage.MemberSettings).click({ force: true }); @@ -191,7 +191,7 @@ Cypress.Commands.add( cy.get(homePage.workspaceList.concat(workspaceName).concat(")")) .closest(homePage.workspaceCompleteSection) - .find(homePage.workspaceNamePopover) + .scrollIntoView() .find(homePage.optionsIcon) .click({ force: true }); cy.xpath(homePage.MemberSettings).click({ force: true }); diff --git a/app/client/cypress/support/commands.js b/app/client/cypress/support/commands.js index 47d1f6ab54..b300978d0c 100644 --- a/app/client/cypress/support/commands.js +++ b/app/client/cypress/support/commands.js @@ -200,7 +200,7 @@ Cypress.Commands.add("DeleteApp", (appName) => { cy.get('button span[icon="chevron-down"]').should("be.visible"); cy.get(homePage.searchInput).clear().type(appName, { force: true }); cy.get(homePage.applicationCard).trigger("mouseover"); - cy.get(homePage.appMoreIcon) + cy.get("[data-testid=t--application-card-context-menu]") .should("have.length", 1) .first() .click({ force: true }); diff --git a/app/client/src/pages/Applications/ApplicationCard.tsx b/app/client/src/pages/Applications/ApplicationCard.tsx index fca8c32e51..65072fe86e 100644 --- a/app/client/src/pages/Applications/ApplicationCard.tsx +++ b/app/client/src/pages/Applications/ApplicationCard.tsx @@ -580,6 +580,7 @@ export function ApplicationCard(props: ApplicationCardProps) {